Title: [226391] trunk/Source/WebKit
Revision
226391
Author
[email protected]
Date
2018-01-03 21:23:54 -0800 (Wed, 03 Jan 2018)

Log Message

REGRESSION (r212929): WKSnapshotConfiguration may leak an NSNumber when deallocated
<https://webkit.org/b/181274>

Reviewed by Joseph Pecoraro.

* UIProcess/API/Cocoa/WKSnapshotConfiguration.mm:
(-[WKSnapshotConfiguration dealloc]): Implement method and
release _snapshotWidth.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (226390 => 226391)


--- trunk/Source/WebKit/ChangeLog	2018-01-04 04:39:33 UTC (rev 226390)
+++ trunk/Source/WebKit/ChangeLog	2018-01-04 05:23:54 UTC (rev 226391)
@@ -1,3 +1,14 @@
+2018-01-03  David Kilzer  <[email protected]>
+
+        REGRESSION (r212929): WKSnapshotConfiguration may leak an NSNumber when deallocated
+        <https://webkit.org/b/181274>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UIProcess/API/Cocoa/WKSnapshotConfiguration.mm:
+        (-[WKSnapshotConfiguration dealloc]): Implement method and
+        release _snapshotWidth.
+
 2018-01-03  John Wilander  <[email protected]>
 
         Storage Access API: Refactor XPC for access removal to go straight from the web process to the network process

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.mm (226390 => 226391)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.mm	2018-01-04 04:39:33 UTC (rev 226390)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.mm	2018-01-04 05:23:54 UTC (rev 226391)
@@ -39,7 +39,13 @@
     return self;
 }
 
+- (void)dealloc
+{
+    [_snapshotWidth release];
 
+    [super dealloc];
+}
+
 - (id)copyWithZone:(NSZone *)zone
 {
     WKSnapshotConfiguration *snapshotConfiguration = [(WKSnapshotConfiguration *)[[self class] allocWithZone:zone] init];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to