Title: [226442] trunk
- Revision
- 226442
- Author
- [email protected]
- Date
- 2018-01-05 03:11:44 -0800 (Fri, 05 Jan 2018)
Log Message
REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=181324
Patch by Fujii Hironori <[email protected]> on 2018-01-05
Reviewed by Konstantin Tokarev.
r226306 changed to use cmake -E copy to copy header files of
DerivedSources. This command copies files unconditionally, then
introduced unnecessary recompilations.
* Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
Modified Paths
Diff
Modified: trunk/ChangeLog (226441 => 226442)
--- trunk/ChangeLog 2018-01-05 10:10:39 UTC (rev 226441)
+++ trunk/ChangeLog 2018-01-05 11:11:44 UTC (rev 226442)
@@ -1,3 +1,16 @@
+2018-01-05 Fujii Hironori <[email protected]>
+
+ REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
+ https://bugs.webkit.org/show_bug.cgi?id=181324
+
+ Reviewed by Konstantin Tokarev.
+
+ r226306 changed to use cmake -E copy to copy header files of
+ DerivedSources. This command copies files unconditionally, then
+ introduced unnecessary recompilations.
+
+ * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
+
2018-01-03 Ting-Wei Lan <[email protected]>
Replace hard-coded paths in shebangs with #!/usr/bin/env
Modified: trunk/Source/cmake/WebKitMacros.cmake (226441 => 226442)
--- trunk/Source/cmake/WebKitMacros.cmake 2018-01-05 10:10:39 UTC (rev 226441)
+++ trunk/Source/cmake/WebKitMacros.cmake 2018-01-05 11:11:44 UTC (rev 226442)
@@ -273,7 +273,7 @@
"file(GLOB headers \"${dir}/*.h\")\n"
"foreach (header IN LISTS headers)\n"
" get_filename_component(header_filename \${header} NAME)\n"
- " execute_process(COMMAND \${CMAKE_COMMAND} -E copy \${header} ${destination}/\${header_filename} RESULT_VARIABLE result)\n"
+ " execute_process(COMMAND \${CMAKE_COMMAND} -E copy_if_different \${header} ${destination}/\${header_filename} RESULT_VARIABLE result)\n"
" if (NOT \${result} EQUAL 0)\n"
" message(FATAL_ERROR \"Failed to copy \${header}: \${result}\")\n"
" endif ()\n"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
