Title: [226503] trunk/Source/WebKitLegacy/mac
- Revision
- 226503
- Author
- [email protected]
- Date
- 2018-01-08 01:22:49 -0800 (Mon, 08 Jan 2018)
Log Message
Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
<https://webkit.org/b/181256>
<rdar://problem/36281730>
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
- Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
to avoid warnings from casting CFStringRef to NPNSString*.
Note that CFMutableStringRef is the same as CFStringRef
without the const modifier, hence its use in the const_cast<>
above.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (226502 => 226503)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-01-08 09:16:58 UTC (rev 226502)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-01-08 09:22:49 UTC (rev 226503)
@@ -1,5 +1,19 @@
2018-01-08 David Kilzer <[email protected]>
+ Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
+ <https://webkit.org/b/181256>
+ <rdar://problem/36281730>
+
+ * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
+ (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
+ - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
+ to avoid warnings from casting CFStringRef to NPNSString*.
+ Note that CFMutableStringRef is the same as CFStringRef
+ without the const modifier, hence its use in the const_cast<>
+ above.
+
+2018-01-08 David Kilzer <[email protected]>
+
Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
<https://webkit.org/b/181256>
<rdar://problem/36281730>
Modified: trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm (226502 => 226503)
--- trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm 2018-01-08 09:16:58 UTC (rev 226502)
+++ trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm 2018-01-08 09:22:49 UTC (rev 226503)
@@ -291,7 +291,7 @@
NPCocoaEvent event;
initializeEvent(&event, NPCocoaEventTextInput);
- event.data.text.text = (NPNSString*)text.get();
+ event.data.text.text = reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>(text.get()));
sendEvent(&event);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
