Title: [226519] trunk/Source/WebKit
- Revision
- 226519
- Author
- [email protected]
- Date
- 2018-01-08 10:37:37 -0800 (Mon, 08 Jan 2018)
Log Message
WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds
https://bugs.webkit.org/show_bug.cgi?id=181384
Patch by Youenn Fablet <[email protected]> on 2018-01-08
Reviewed by Chris Dumez.
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::terminateServiceWorkerProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (226518 => 226519)
--- trunk/Source/WebKit/ChangeLog 2018-01-08 18:33:24 UTC (rev 226518)
+++ trunk/Source/WebKit/ChangeLog 2018-01-08 18:37:37 UTC (rev 226519)
@@ -1,3 +1,13 @@
+2018-01-08 Youenn Fablet <[email protected]>
+
+ WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds
+ https://bugs.webkit.org/show_bug.cgi?id=181384
+
+ Reviewed by Chris Dumez.
+
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::terminateServiceWorkerProcess):
+
2018-01-08 Frederic Wang <[email protected]>
Unreviewed build fix after r226211.
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (226518 => 226519)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-01-08 18:33:24 UTC (rev 226518)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-01-08 18:37:37 UTC (rev 226519)
@@ -1458,6 +1458,9 @@
if (!m_serviceWorkerProcess)
return;
+#ifndef NDEBUG
+ auto protectedThis = makeRef(*this);
+#endif
m_serviceWorkerProcess->requestTermination(ProcessTerminationReason::RequestedByClient);
ASSERT(!m_processes.contains(m_serviceWorkerProcess));
ASSERT(!m_serviceWorkerProcess);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
