Title: [226525] tags/Safari-605.1.19.1

Diff

Modified: tags/Safari-605.1.19.1/LayoutTests/ChangeLog (226524 => 226525)


--- tags/Safari-605.1.19.1/LayoutTests/ChangeLog	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/LayoutTests/ChangeLog	2018-01-08 18:55:10 UTC (rev 226525)
@@ -1,5 +1,22 @@
 2018-01-08  Jason Marcell  <[email protected]>
 
+        Cherry-pick r226495. rdar://problem/36085943
+
+    2018-01-07  Ryosuke Niwa  <[email protected]>
+
+            Reduce the precision of "high" resolution time to 1ms
+            https://bugs.webkit.org/show_bug.cgi?id=180910
+            <rdar://problem/36085943>
+
+            Reviewed by Saam Barati.
+
+            Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+            due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+            * TestExpectations:
+
+2018-01-08  Jason Marcell  <[email protected]>
+
         Cherry-pick r226386. rdar://problem/36077849
 
     2018-01-03  Michael Saboff  <[email protected]>

Modified: tags/Safari-605.1.19.1/LayoutTests/TestExpectations (226524 => 226525)


--- tags/Safari-605.1.19.1/LayoutTests/TestExpectations	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/LayoutTests/TestExpectations	2018-01-08 18:55:10 UTC (rev 226525)
@@ -1669,3 +1669,6 @@
 webkit.org/b/158205 applicationmanifest/ [ Skip ]
 
 webkit.org/b/178785 perf/object-keys.html [ Pass Failure ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]

Modified: tags/Safari-605.1.19.1/Source/WebCore/ChangeLog (226524 => 226525)


--- tags/Safari-605.1.19.1/Source/WebCore/ChangeLog	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/Source/WebCore/ChangeLog	2018-01-08 18:55:10 UTC (rev 226525)
@@ -1,5 +1,26 @@
 2018-01-08  Jason Marcell  <[email protected]>
 
+        Cherry-pick r226495. rdar://problem/36085943
+
+    2018-01-07  Ryosuke Niwa  <[email protected]>
+
+            Reduce the precision of "high" resolution time to 1ms
+            https://bugs.webkit.org/show_bug.cgi?id=180910
+            <rdar://problem/36085943>
+
+            Reviewed by Saam Barati.
+
+            Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+            Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+            * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+            (WebCore::fillRTCStats):
+            * page/Performance.cpp:
+            (WebCore::Performance::reduceTimeResolution):
+
+2018-01-08  Jason Marcell  <[email protected]>
+
         Cherry-pick r226371. rdar://problem/36146670
 
     2018-01-03  Joseph Pecoraro  <[email protected]>

Modified: tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226524 => 226525)


--- tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 18:55:10 UTC (rev 226525)
@@ -35,6 +35,7 @@
 #include "Logging.h"
 #include "MediaStreamEvent.h"
 #include "NotImplemented.h"
+#include "Performance.h"
 #include "PlatformStrategies.h"
 #include "RTCDataChannel.h"
 #include "RTCDataChannelEvent.h"
@@ -50,6 +51,7 @@
 #include <webrtc/p2p/base/basicpacketsocketfactory.h>
 #include <webrtc/p2p/client/basicportallocator.h>
 #include <webrtc/pc/peerconnectionfactory.h>
+#include <wtf/CurrentTime.h>
 #include <wtf/MainThread.h>
 
 #include <pal/cf/CoreMediaSoftLink.h>
@@ -310,7 +312,7 @@
 
 static inline void fillRTCStats(RTCStatsReport::Stats& stats, const webrtc::RTCStats& rtcStats)
 {
-    stats.timestamp = rtcStats.timestamp_us() / 1000.0;
+    stats.timestamp = Performance::reduceTimeResolution(Seconds::fromMicroseconds(rtcStats.timestamp_us())).milliseconds();
     stats.id = fromStdString(rtcStats.id());
 }
 

Modified: tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp (226524 => 226525)


--- tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp	2018-01-08 18:55:10 UTC (rev 226525)
@@ -75,7 +75,7 @@
 
 Seconds Performance::reduceTimeResolution(Seconds seconds)
 {
-    double resolution = (100_us).seconds();
+    double resolution = (1000_us).seconds();
     double reduced = std::floor(seconds.seconds() / resolution) * resolution;
     return Seconds(reduced);
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to