Title: [226630] trunk/Source/WebCore
- Revision
- 226630
- Author
- [email protected]
- Date
- 2018-01-09 06:43:28 -0800 (Tue, 09 Jan 2018)
Log Message
[GStreamer] Ensure SleepDisabler is not held by pages in page cache
https://bugs.webkit.org/show_bug.cgi?id=180197
Reviewed by Eric Carlson.
The sleep disabler is now checked again whenever the media player
playback state or other characteristic has changed in the media
engine.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
Check if the sleep disabler state needs to be updated or not.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
(WebCore::HTMLMediaElement::shouldDisableSleep const): Enable
sleep disabler for GTK and WPE ports.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (226629 => 226630)
--- trunk/Source/WebCore/ChangeLog 2018-01-09 13:59:47 UTC (rev 226629)
+++ trunk/Source/WebCore/ChangeLog 2018-01-09 14:43:28 UTC (rev 226630)
@@ -1,5 +1,23 @@
2018-01-09 Philippe Normand <[email protected]>
+ [GStreamer] Ensure SleepDisabler is not held by pages in page cache
+ https://bugs.webkit.org/show_bug.cgi?id=180197
+
+ Reviewed by Eric Carlson.
+
+ The sleep disabler is now checked again whenever the media player
+ playback state or other characteristic has changed in the media
+ engine.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
+ Check if the sleep disabler state needs to be updated or not.
+ (WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
+ (WebCore::HTMLMediaElement::shouldDisableSleep const): Enable
+ sleep disabler for GTK and WPE ports.
+
+2018-01-09 Philippe Normand <[email protected]>
+
[GStreamer] Missing notifications to player client
https://bugs.webkit.org/show_bug.cgi?id=181432
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (226629 => 226630)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2018-01-09 13:59:47 UTC (rev 226629)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2018-01-09 14:43:28 UTC (rev 226630)
@@ -4848,6 +4848,9 @@
pauseInternal();
else
playInternal();
+
+ updateSleepDisabling();
+
endProcessingMediaPlayerCallback();
}
@@ -5022,6 +5025,8 @@
m_mediaSession->canProduceAudioChanged();
+ updateSleepDisabling();
+
endProcessingMediaPlayerCallback();
}
@@ -6636,8 +6641,7 @@
HTMLMediaElement::SleepType HTMLMediaElement::shouldDisableSleep() const
{
- // See https://bugs.webkit.org/show_bug.cgi?id=180197 before removing this guard.
-#if !PLATFORM(COCOA)
+#if !PLATFORM(COCOA) && !PLATFORM(GTK) && !PLATFORM(WPE)
return SleepType::None;
#endif
if (!m_player || m_player->paused() || loop())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
