Title: [226646] trunk/LayoutTests
Revision
226646
Author
[email protected]
Date
2018-01-09 10:24:55 -0800 (Tue, 09 Jan 2018)

Log Message

[iOS Debug WK2] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=181087
<rdar://problem/36188109>

Patch by Youenn Fablet <[email protected]> on 2018-01-09
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Updated test to get a more deterministic output.

* web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt:
* web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html:

LayoutTests:

* platform/ios-wk2/TestExpectations: Removed flaky expectation.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (226645 => 226646)


--- trunk/LayoutTests/ChangeLog	2018-01-09 17:55:22 UTC (rev 226645)
+++ trunk/LayoutTests/ChangeLog	2018-01-09 18:24:55 UTC (rev 226646)
@@ -1,3 +1,13 @@
+2018-01-09  Youenn Fablet  <[email protected]>
+
+        [iOS Debug WK2] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=181087
+        <rdar://problem/36188109>
+
+        Reviewed by Chris Dumez.
+
+        * platform/ios-wk2/TestExpectations: Removed flaky expectation.
+
 2018-01-09  Yacine Bandou  <[email protected]>
 
         [EME] Add layout test for clearKey CENC message event

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226645 => 226646)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-09 17:55:22 UTC (rev 226645)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-09 18:24:55 UTC (rev 226646)
@@ -1,5 +1,18 @@
 2018-01-09  Youenn Fablet  <[email protected]>
 
+        [iOS Debug WK2] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=181087
+        <rdar://problem/36188109>
+
+        Reviewed by Chris Dumez.
+
+        Updated test to get a more deterministic output.
+
+        * web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt:
+        * web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html:
+
+2018-01-09  Youenn Fablet  <[email protected]>
+
         Add CSP support to service workers
         https://bugs.webkit.org/show_bug.cgi?id=181385
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt (226645 => 226646)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt	2018-01-09 17:55:22 UTC (rev 226645)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt	2018-01-09 18:24:55 UTC (rev 226646)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: serviceWorker.register() must be called with a valid relative script URL
+CONSOLE MESSAGE: line 11: Unhandled Promise Rejection: TypeError: serviceWorker.register() must be called with a valid relative script URL
 
 PASS Call register() on ServiceWorkerContainer owned by closed window. 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html (226645 => 226646)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html	2018-01-09 17:55:22 UTC (rev 226645)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html	2018-01-09 18:24:55 UTC (rev 226646)
@@ -1,14 +1,17 @@
 <html>
 <head>
 <script>
-window.addEventListener('message', function(evt) {
+window.addEventListener('message', async function(evt) {
   if (evt.data ="" 'START') {
     var w = window.open('./');
     var sw = w.navigator.serviceWorker;
     w.close();
     w = null;
-    sw.register('doesntmatter.js');
-    parent.postMessage('OK', '*');
+    try {
+      await sw.register('doesntmatter.js');
+    } finally {
+      parent.postMessage('OK', '*');
+    }
   }
 });
 </script>

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (226645 => 226646)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-01-09 17:55:22 UTC (rev 226645)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-01-09 18:24:55 UTC (rev 226646)
@@ -1294,6 +1294,3 @@
 webkit.org/b/181166 imported/w3c/web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https.html [ Pass Failure ]
 
 webkit.org/181167 imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html [ Pass Failure ]
-
-webkit.org/181087 imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html [ Pass Failure ]
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to