Title: [226700] releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI
Revision
226700
Author
[email protected]
Date
2018-01-10 00:34:43 -0800 (Wed, 10 Jan 2018)

Log Message

Merge r221800 - Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
https://bugs.webkit.org/show_bug.cgi?id=176633

Patch by Joseph Pecoraro <[email protected]> on 2017-09-08
Reviewed by Michael Saboff.

* UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI/ChangeLog (226699 => 226700)


--- releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI/ChangeLog	2018-01-10 08:33:22 UTC (rev 226699)
+++ releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI/ChangeLog	2018-01-10 08:34:43 UTC (rev 226700)
@@ -1,3 +1,14 @@
+2017-09-08  Joseph Pecoraro  <[email protected]>
+
+        Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
+        https://bugs.webkit.org/show_bug.cgi?id=176633
+
+        Reviewed by Michael Saboff.
+
+        * UserInterface/Proxies/HeapSnapshotDiffProxy.js:
+        (WI.HeapSnapshotDiffProxy):
+        This class has listeners of another object's events. It should extend WI.Object.
+
 2017-08-14  Simon Fraser  <[email protected]>
 
         Remove Proximity Events and related code

Modified: releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotDiffProxy.js (226699 => 226700)


--- releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotDiffProxy.js	2018-01-10 08:33:22 UTC (rev 226699)
+++ releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotDiffProxy.js	2018-01-10 08:34:43 UTC (rev 226700)
@@ -23,10 +23,12 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-WI.HeapSnapshotDiffProxy = class HeapSnapshotDiffProxy
+WI.HeapSnapshotDiffProxy = class HeapSnapshotDiffProxy extends WI.Object
 {
     constructor(snapshotDiffObjectId, snapshot1, snapshot2, totalSize, totalObjectCount, categories)
     {
+        super();
+
         this._proxyObjectId = snapshotDiffObjectId;
 
         console.assert(snapshot1 instanceof WI.HeapSnapshotProxy);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to