[webkit-changes] [226713] trunk/Source/WebCore

[philn]

Title: [226713] trunk/Source/WebCore

Revision

226713

Author

ph...@webkit.org

Date

2018-01-10 07:29:00 -0800 (Wed, 10 Jan 2018)

Log Message

[GStreamer] fix critical GObject warning

Rubber-stamped by Carlos Garcia Campos.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): No need to
resort to complicated things to get the element name...

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

Diff

Modified: trunk/Source/WebCore/ChangeLog (226712 => 226713)

--- trunk/Source/WebCore/ChangeLog	2018-01-10 15:26:07 UTC (rev 226712)
+++ trunk/Source/WebCore/ChangeLog	2018-01-10 15:29:00 UTC (rev 226713)
@@ -1,5 +1,15 @@
 2018-01-10  Philippe Normand  <pnorm...@igalia.com>
 
+        [GStreamer] fix critical GObject warning
+
+        Rubber-stamped by Carlos Garcia Campos.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::handleMessage): No need to
+        resort to complicated things to get the element name...
+
+2018-01-10  Philippe Normand  <pnorm...@igalia.com>
+
         [GStreamer] REGRESSION(r226629): broke media/video-interruption-with-resume-allowing-play.html
         https://bugs.webkit.org/show_bug.cgi?id=181471
         <rdar://problem/36402323>

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (226712 => 226713)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2018-01-10 15:26:07 UTC (rev 226712)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2018-01-10 15:29:00 UTC (rev 226713)
@@ -988,8 +988,7 @@
         gst_message_parse_request_state(message, &requestedState);
         gst_element_get_state(m_pipeline.get(), &currentState, nullptr, 250 * GST_NSECOND);
         if (requestedState < currentState) {
-            GUniquePtr<gchar> elementName(gst_element_get_name(GST_ELEMENT(message)));
-            GST_INFO("Element %s requested state change to %s", elementName.get(),
+            GST_INFO("Element %s requested state change to %s", GST_MESSAGE_SRC_NAME(message),
                 gst_element_state_get_name(requestedState));
             m_requestedState = requestedState;
             if (!changePipelineState(requestedState))

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes