Title: [226762] trunk/Source/WebKit
Revision
226762
Author
[email protected]
Date
2018-01-10 22:34:22 -0800 (Wed, 10 Jan 2018)

Log Message

-[WKWebView _web_gestureEventWasNotHandledByWebCore:] should call -_gestureEventWasNotHandledByWebCore:
https://bugs.webkit.org/show_bug.cgi?id=181498

Reviewed by Alex Christensen.

WKView's API contract allows clients to override -_gestureEventWasNotHandledByWebCore:, and -[WKView
_web_gestureEventWasNotHandledByWebCore:] calls -_gestureEventWasNotHandledByWebCore: instead of
invoking WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly() directly. WKWebView should do
the same thing.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _web_gestureEventWasNotHandledByWebCore:]):
Call -_gestureEventWasNotHandledByWebCore:, which will call gestureEventWasNotHandledByWebCoreFromViewOnly().

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (226761 => 226762)


--- trunk/Source/WebKit/ChangeLog	2018-01-11 06:13:01 UTC (rev 226761)
+++ trunk/Source/WebKit/ChangeLog	2018-01-11 06:34:22 UTC (rev 226762)
@@ -1,3 +1,19 @@
+2018-01-10  Jeff Miller  <[email protected]>
+
+        -[WKWebView _web_gestureEventWasNotHandledByWebCore:] should call -_gestureEventWasNotHandledByWebCore:
+        https://bugs.webkit.org/show_bug.cgi?id=181498
+
+        Reviewed by Alex Christensen.
+
+        WKView's API contract allows clients to override -_gestureEventWasNotHandledByWebCore:, and -[WKView
+        _web_gestureEventWasNotHandledByWebCore:] calls -_gestureEventWasNotHandledByWebCore: instead of
+        invoking WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly() directly. WKWebView should do
+        the same thing.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _web_gestureEventWasNotHandledByWebCore:]):
+        Call -_gestureEventWasNotHandledByWebCore:, which will call gestureEventWasNotHandledByWebCoreFromViewOnly().
+
 2018-01-10  Wenson Hsieh  <[email protected]>
 
         REGRESSION(r222507): Composition highlight doesn't render when using IME

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (226761 => 226762)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-01-11 06:13:01 UTC (rev 226761)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-01-11 06:34:22 UTC (rev 226762)
@@ -3853,7 +3853,7 @@
 
 - (void)_web_gestureEventWasNotHandledByWebCore:(NSEvent *)event
 {
-    _impl->gestureEventWasNotHandledByWebCoreFromViewOnly(event);
+    [self _gestureEventWasNotHandledByWebCore:event];
 }
 
 #endif // PLATFORM(MAC)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to