Title: [100617] trunk/Source/WebKit2
- Revision
- 100617
- Author
- [email protected]
- Date
- 2011-11-17 06:51:52 -0800 (Thu, 17 Nov 2011)
Log Message
[Qt][WK2] Cleanup dead code in QtWebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=72608
Reviewed by Simon Hausmann.
Remove some dead code after we merged our views.
QQuickWebView is now using AC which means that this
path is never called now.
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didReceiveDownloadResponse):
* UIProcess/qt/QtWebPageProxy.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (100616 => 100617)
--- trunk/Source/WebKit2/ChangeLog 2011-11-17 14:49:35 UTC (rev 100616)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-17 14:51:52 UTC (rev 100617)
@@ -1,3 +1,18 @@
+2011-11-17 Alexis Menard <[email protected]>
+
+ [Qt][WK2] Cleanup dead code in QtWebPageProxy.
+ https://bugs.webkit.org/show_bug.cgi?id=72608
+
+ Reviewed by Simon Hausmann.
+
+ Remove some dead code after we merged our views.
+ QQuickWebView is now using AC which means that this
+ path is never called now.
+
+ * UIProcess/qt/QtWebPageProxy.cpp:
+ (QtWebPageProxy::didReceiveDownloadResponse):
+ * UIProcess/qt/QtWebPageProxy.h:
+
2011-11-17 Tor Arne Vestbø <[email protected]>
[Qt] Remove forwarding header for WebKit2 C API
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (100616 => 100617)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-11-17 14:49:35 UTC (rev 100616)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-11-17 14:51:52 UTC (rev 100617)
@@ -607,14 +607,6 @@
m_viewInterface->didChangeLoadProgress(newLoadProgress);
}
-void QtWebPageProxy::paint(QPainter* painter, const QRect& area)
-{
- if (m_webPageProxy->isValid())
- paintContent(painter, area);
- else
- painter->fillRect(area, Qt::white);
-}
-
bool QtWebPageProxy::canGoBack() const
{
return m_webPageProxy->canGoBack();
@@ -821,13 +813,6 @@
m_viewInterface->downloadRequested(download);
}
-void QtWebPageProxy::paintContent(QPainter* painter, const QRect& area)
-{
- // FIXME: Do something with the unpainted region?
- WebCore::Region unpaintedRegion;
- static_cast<DrawingAreaProxyImpl*>(m_webPageProxy->drawingArea())->paint(painter, area, unpaintedRegion);
-}
-
PassOwnPtr<DrawingAreaProxy> QtWebPageProxy::createDrawingAreaProxy()
{
return DrawingAreaProxyImpl::create(m_webPageProxy.get());
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h (100616 => 100617)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h 2011-11-17 14:49:35 UTC (rev 100616)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h 2011-11-17 14:51:52 UTC (rev 100617)
@@ -147,8 +147,6 @@
void didChangeLoadProgress(int);
int loadProgress() const { return m_loadProgress; }
- void paint(QPainter*, const QRect&);
-
bool canGoBack() const;
void goBack();
bool canGoForward() const;
@@ -211,7 +209,6 @@
Q_SIGNAL void receivedMessageFromNavigatorQtObject(const QVariantMap&);
protected:
- virtual void paintContent(QPainter* painter, const QRect& area);
RefPtr<WebKit::WebPageProxy> m_webPageProxy;
WebKit::QtViewInterface* const m_viewInterface;
QtViewportInteractionEngine* m_interactionEngine;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
