Title: [226827] branches/safari-605-branch/Source/WebCore

Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-12 01:50:29 UTC (rev 226827)
@@ -1,3 +1,7 @@
+2018-01-11  Jason Marcell  <[email protected]>
+
+        Revert r226273. rdar://problem/36196266
+
 2018-01-09  Jason Marcell  <[email protected]>
 
         Cherry-pick r226638. rdar://problem/36392286

Modified: branches/safari-605-branch/Source/WebCore/Sources.txt (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/Sources.txt	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/Sources.txt	2018-01-12 01:50:29 UTC (rev 226827)
@@ -1985,7 +1985,6 @@
 
 rendering/updating/RenderTreeBuilder.cpp
 rendering/updating/RenderTreeBuilderFirstLetter.cpp
-rendering/updating/RenderTreeBuilderFormControls.cpp
 rendering/updating/RenderTreeBuilderList.cpp
 rendering/updating/RenderTreeBuilderMultiColumn.cpp
 rendering/updating/RenderTreeBuilderRuby.cpp

Modified: branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-12 01:50:29 UTC (rev 226827)
@@ -392,7 +392,6 @@
 		113D0B521F9FDD2B00F611BB /* LayoutContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 113D0B501F9FDD2B00F611BB /* LayoutContext.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		119340791FE8B92300935F1E /* RenderTreeBuilderTable.h in Headers */ = {isa = PBXBuildFile; fileRef = 119340771FE8B92300935F1E /* RenderTreeBuilderTable.h */; };
 		1193408A1FEB355D00935F1E /* RenderTreeBuilderRuby.h in Headers */ = {isa = PBXBuildFile; fileRef = 119340881FEB355D00935F1E /* RenderTreeBuilderRuby.h */; };
-		119340971FED715500935F1E /* RenderTreeBuilderFormControls.h in Headers */ = {isa = PBXBuildFile; fileRef = 119340951FED715500935F1E /* RenderTreeBuilderFormControls.h */; };
 		11E067EE1E6246E500162D16 /* SimpleLineLayoutCoverage.h in Headers */ = {isa = PBXBuildFile; fileRef = 11E067ED1E6246E500162D16 /* SimpleLineLayoutCoverage.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1400D7A817136EA70077CE05 /* ScriptWrappableInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 1400D7A717136EA70077CE05 /* ScriptWrappableInlines.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		1403B99709EB13AF00797C7F /* DOMWindow.h in Headers */ = {isa = PBXBuildFile; fileRef = 1403B99509EB13AF00797C7F /* DOMWindow.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -5586,8 +5585,6 @@
 		119340771FE8B92300935F1E /* RenderTreeBuilderTable.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderTable.h; sourceTree = "<group>"; };
 		119340871FEB355D00935F1E /* RenderTreeBuilderRuby.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeBuilderRuby.cpp; sourceTree = "<group>"; };
 		119340881FEB355D00935F1E /* RenderTreeBuilderRuby.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderRuby.h; sourceTree = "<group>"; };
-		119340941FED715500935F1E /* RenderTreeBuilderFormControls.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeBuilderFormControls.cpp; sourceTree = "<group>"; };
-		119340951FED715500935F1E /* RenderTreeBuilderFormControls.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderFormControls.h; sourceTree = "<group>"; };
 		11E067EB1E62461300162D16 /* SimpleLineLayoutCoverage.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SimpleLineLayoutCoverage.cpp; sourceTree = "<group>"; };
 		11E067ED1E6246E500162D16 /* SimpleLineLayoutCoverage.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SimpleLineLayoutCoverage.h; sourceTree = "<group>"; };
 		1400D7A717136EA70077CE05 /* ScriptWrappableInlines.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScriptWrappableInlines.h; sourceTree = "<group>"; };
@@ -24628,8 +24625,6 @@
 				E47C392A1FE6E0DE00BBBC6B /* RenderTreeBuilder.h */,
 				E47C39211FE6E0DA00BBBC6B /* RenderTreeBuilderFirstLetter.cpp */,
 				E47C39261FE6E0DC00BBBC6B /* RenderTreeBuilderFirstLetter.h */,
-				119340941FED715500935F1E /* RenderTreeBuilderFormControls.cpp */,
-				119340951FED715500935F1E /* RenderTreeBuilderFormControls.h */,
 				E47C392B1FE6E0DF00BBBC6B /* RenderTreeBuilderList.cpp */,
 				E47C39281FE6E0DD00BBBC6B /* RenderTreeBuilderList.h */,
 				E47C39231FE6E0DA00BBBC6B /* RenderTreeBuilderMultiColumn.cpp */,
@@ -25512,12 +25507,12 @@
 				C3CF17A315B0063F00276D39 /* IdTargetObserverRegistry.h */,
 				8AB4BC76126FDB7100DEB727 /* IgnoreDestructiveWriteCountIncrementer.h */,
 				467302011C4EFE6600BCB357 /* IgnoreOpensDuringUnloadCountIncrementer.h */,
+				512B57BF1FE9902E000A1E5E /* InProcessMessagePortChannel.cpp */,
+				512B57BC1FE9902C000A1E5E /* InProcessMessagePortChannel.h */,
 				E30592611E27A38C00D57C98 /* InlineClassicScript.cpp */,
 				E30592621E27A38C00D57C98 /* InlineClassicScript.h */,
 				AA4C3A740B2B1679002334A2 /* InlineStyleSheetOwner.cpp */,
 				AA4C3A750B2B1679002334A2 /* InlineStyleSheetOwner.h */,
-				512B57BF1FE9902E000A1E5E /* InProcessMessagePortChannel.cpp */,
-				512B57BC1FE9902C000A1E5E /* InProcessMessagePortChannel.h */,
 				2EB767551DA19B99003E23B5 /* InputEvent.cpp */,
 				2EB767541DA19B67003E23B5 /* InputEvent.h */,
 				2EB767531DA19313003E23B5 /* InputEvent.idl */,
@@ -25649,9 +25644,9 @@
 				9BD0BF9112A42BF50072FD43 /* ScopedEventQueue.h */,
 				A84D82C011D3474800972990 /* ScriptableDocumentParser.cpp */,
 				A84D82BF11D3474800972990 /* ScriptableDocumentParser.h */,
-				E46B41F81CB24E70008F11DE /* ScriptDisallowedScope.h */,
 				4998AECF13FB224D0090B1AA /* ScriptedAnimationController.cpp */,
 				4998AED013FB224D0090B1AA /* ScriptedAnimationController.h */,
+				E46B41F81CB24E70008F11DE /* ScriptDisallowedScope.h */,
 				08A484750E5272C500C3FE76 /* ScriptElement.cpp */,
 				08A484760E5272C500C3FE76 /* ScriptElement.h */,
 				E3E4E2A51E3B16FC0023BB8A /* ScriptElementCachedScriptFetcher.cpp */,
@@ -27482,7 +27477,6 @@
 				BCEA485A097D93020094C9E4 /* InlineTextBox.h in Headers */,
 				1C010701192594DF008A4201 /* InlineTextBoxStyle.h in Headers */,
 				510A58E51BAA40B100C19282 /* InProcessIDBServer.h in Headers */,
-				512B57C01FE99083000A1E5E /* InProcessMessagePortChannel.h in Headers */,
 				2EB767571DA19BDF003E23B5 /* InputEvent.h in Headers */,
 				37E3524D12450C6600BAF5D9 /* InputType.h in Headers */,
 				C348612415FDE21E007A1CC9 /* InputTypeNames.h in Headers */,
@@ -28640,6 +28634,7 @@
 				63D7B32D0E78CD3F00F7617C /* NodeRenderStyle.h in Headers */,
 				E43105BB16750F1600DB2FB8 /* NodeTraversal.h in Headers */,
 				9382AAB40D8C386100F357A6 /* NodeWithIndex.h in Headers */,
+				E46B41F91CB24E70008F11DE /* ScriptDisallowedScope.h in Headers */,
 				312C0C41146DC6CC0016C911 /* Notification.h in Headers */,
 				33503C9A10179A74003B47E1 /* NotificationClient.h in Headers */,
 				3128CA6B147331630074C72A /* NotificationController.h in Headers */,
@@ -28801,6 +28796,7 @@
 				CEEFCD7C19DB33DC003876D7 /* PlatformMediaResourceLoader.h in Headers */,
 				070E09191875EEFC003A1D3C /* PlatformMediaSession.h in Headers */,
 				07F944161864D046005D31CB /* PlatformMediaSessionManager.h in Headers */,
+				41BF70100FE86F61005E8DEC /* PlatformMessagePortChannel.h in Headers */,
 				935C476909AC4D4300A6AAB4 /* PlatformMouseEvent.h in Headers */,
 				C598905814E9C29900E8D18B /* PlatformPasteboard.h in Headers */,
 				BCEC01D70C274EB4009F4EC9 /* PlatformScreen.h in Headers */,
@@ -29054,7 +29050,6 @@
 				93F1998C08245E59001E9ABC /* RenderTreeAsText.h in Headers */,
 				E47C392D1FE6E0F300BBBC6B /* RenderTreeBuilder.h in Headers */,
 				E47C39301FE6E0FD00BBBC6B /* RenderTreeBuilderFirstLetter.h in Headers */,
-				119340971FED715500935F1E /* RenderTreeBuilderFormControls.h in Headers */,
 				E47C39321FE6E10500BBBC6B /* RenderTreeBuilderList.h in Headers */,
 				E47C39331FE6E10800BBBC6B /* RenderTreeBuilderMultiColumn.h in Headers */,
 				1193408A1FEB355D00935F1E /* RenderTreeBuilderRuby.h in Headers */,
@@ -29164,7 +29159,6 @@
 				A84D82C111D3474800972990 /* ScriptableDocumentParser.h in Headers */,
 				41F1D21F0EF35C2A00DA8753 /* ScriptCachedFrameData.h in Headers */,
 				93B70D7009EB0C7C009D8468 /* ScriptController.h in Headers */,
-				E46B41F91CB24E70008F11DE /* ScriptDisallowedScope.h in Headers */,
 				4998AED213FB224D0090B1AA /* ScriptedAnimationController.h in Headers */,
 				08A484780E5272C500C3FE76 /* ScriptElement.h in Headers */,
 				E3E4E2A81E3B17100023BB8A /* ScriptElementCachedScriptFetcher.h in Headers */,
@@ -29921,6 +29915,7 @@
 				A5B81CB51FAA44620037D1E6 /* WebConsoleAgent.h in Headers */,
 				9BBA2CAB1F679E0C00FD1C1E /* WebContentReader.h in Headers */,
 				419BE7591BC7F42B00E1C85B /* WebCoreBuiltinNames.h in Headers */,
+				512B57C01FE99083000A1E5E /* InProcessMessagePortChannel.h in Headers */,
 				2D3EF44A1917915C00034184 /* WebCoreCALayerExtras.h in Headers */,
 				515F79541CFCA3D500CCED93 /* WebCoreCrossThreadCopier.h in Headers */,
 				CD5D27781E8318E000D80A3D /* WebCoreDecompressionSession.h in Headers */,

Modified: branches/safari-605-branch/Source/WebCore/rendering/RenderButton.cpp (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/RenderButton.cpp	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/RenderButton.cpp	2018-01-12 01:50:29 UTC (rev 226827)
@@ -67,7 +67,6 @@
 {
     ASSERT(!m_inner.get());
     m_inner = makeWeakPtr(innerRenderer);
-    updateAnonymousChildStyle(m_inner->mutableStyle());
 }
 
 RenderPtr<RenderObject> RenderButton::takeChild(RenderObject& oldChild)

Modified: branches/safari-605-branch/Source/WebCore/rendering/RenderMenuList.cpp (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/RenderMenuList.cpp	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/RenderMenuList.cpp	2018-01-12 01:50:29 UTC (rev 226827)
@@ -100,11 +100,20 @@
     RenderFlexibleBox::willBeDestroyed();
 }
 
-void RenderMenuList::setInnerRenderer(RenderBlock& innerRenderer)
+void RenderMenuList::createInnerBlock()
 {
-    ASSERT(!m_innerBlock.get());
-    m_innerBlock = makeWeakPtr(innerRenderer);
+    if (m_innerBlock) {
+        ASSERT(firstChild() == m_innerBlock);
+        ASSERT(!m_innerBlock->nextSibling());
+        return;
+    }
+
+    // Create an anonymous block.
+    ASSERT(!firstChild());
+    auto newInnerBlock = createAnonymousBlock();
+    m_innerBlock = makeWeakPtr(*newInnerBlock.get());
     adjustInnerStyle();
+    RenderFlexibleBox::addChild(*RenderTreeBuilder::current(), WTFMove(newInnerBlock));
 }
 
 void RenderMenuList::adjustInnerStyle()
@@ -166,10 +175,15 @@
     return downcast<HTMLSelectElement>(nodeForNonAnonymous());
 }
 
-void RenderMenuList::addChild(RenderTreeBuilder&, RenderPtr<RenderObject> child, RenderObject*)
+void RenderMenuList::addChild(RenderTreeBuilder& builder, RenderPtr<RenderObject> newChild, RenderObject* beforeChild)
 {
+    createInnerBlock();
+    auto& child = *newChild;
+    builder.insertChild(*m_innerBlock, WTFMove(newChild), beforeChild);
+    ASSERT(m_innerBlock == firstChild());
+
     if (AXObjectCache* cache = document().existingAXObjectCache())
-        cache->childrenChanged(this, child.get());
+        cache->childrenChanged(this, &child);
 }
 
 RenderPtr<RenderObject> RenderMenuList::takeChild(RenderObject& oldChild)
@@ -360,7 +374,10 @@
     if (m_popupIsVisible)
         return;
 
-    ASSERT(m_innerBlock);
+    // Create m_innerBlock here so it ends up as the first child.
+    // This is important because otherwise we might try to create m_innerBlock
+    // inside the showPopup call and it would fail.
+    createInnerBlock();
     if (!m_popup)
         m_popup = document().page()->chrome().createPopupMenu(*this);
     m_popupIsVisible = true;

Modified: branches/safari-605-branch/Source/WebCore/rendering/RenderMenuList.h (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/RenderMenuList.h	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/RenderMenuList.h	2018-01-12 01:50:29 UTC (rev 226827)
@@ -59,9 +59,6 @@
 
     String text() const;
 
-    RenderBlock* innerRenderer() const { return m_innerBlock.get(); }
-    void setInnerRenderer(RenderBlock&);
-
 private:
     void willBeDestroyed() override;
 
@@ -130,6 +127,7 @@
 
     void getItemBackgroundColor(unsigned listIndex, Color&, bool& itemHasCustomBackgroundColor) const;
 
+    void createInnerBlock();
     void adjustInnerStyle();
     void setText(const String&);
     void setTextFromOption(int optionIndex);

Modified: branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp	2018-01-12 01:50:29 UTC (rev 226827)
@@ -34,7 +34,6 @@
 #include "RenderTableRow.h"
 #include "RenderText.h"
 #include "RenderTreeBuilderFirstLetter.h"
-#include "RenderTreeBuilderFormControls.h"
 #include "RenderTreeBuilderList.h"
 #include "RenderTreeBuilderMultiColumn.h"
 #include "RenderTreeBuilderRuby.h"
@@ -51,7 +50,6 @@
     , m_multiColumnBuilder(std::make_unique<MultiColumn>(*this))
     , m_tableBuilder(std::make_unique<Table>(*this))
     , m_rubyBuilder(std::make_unique<Ruby>(*this))
-    , m_formControlsBuilder(std::make_unique<FormControls>(*this))
 {
     RELEASE_ASSERT(!s_current || &m_view != &s_current->m_view);
     m_previous = s_current;
@@ -63,6 +61,19 @@
     s_current = m_previous;
 }
 
+static RenderBlock& createInnerRendererForButtonIfNeeded(RenderButton& button, RenderTreeBuilder& builder)
+{
+    auto* innerRenderer = button.innerRenderer();
+    if (innerRenderer)
+        return *innerRenderer;
+    auto wrapper = button.createAnonymousBlock(button.style().display());
+    innerRenderer = wrapper.get();
+    button.updateAnonymousChildStyle(wrapper->mutableStyle());
+    button.RenderFlexibleBox::addChild(builder, WTFMove(wrapper));
+    button.setInnerRenderer(*innerRenderer);
+    return *innerRenderer;
+}
+
 void RenderTreeBuilder::insertChild(RenderElement& parent, RenderPtr<RenderObject> child, RenderObject* beforeChild)
 {
     auto insertRecursiveIfNeeded = [&](RenderElement& parentCandidate) {
@@ -111,15 +122,9 @@
     }
 
     if (is<RenderButton>(parent)) {
-        insertRecursiveIfNeeded(formControlsBuilder().createInnerRendererIfNeeded(downcast<RenderButton>(parent)));
+        insertRecursiveIfNeeded(createInnerRendererForButtonIfNeeded(downcast<RenderButton>(parent), *this));
         return;
     }
-
-    if (is<RenderMenuList>(parent)) {
-        insertRecursiveIfNeeded(formControlsBuilder().createInnerRendererIfNeeded(downcast<RenderMenuList>(parent)));
-        return;
-    }
-
     parent.addChild(*this, WTFMove(child), beforeChild);
 }
 

Modified: branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.h (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.h	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.h	2018-01-12 01:50:29 UTC (rev 226827)
@@ -52,7 +52,6 @@
     class MultiColumn;
     class Table;
     class Ruby;
-    class FormControls;
 
     FirstLetter& firstLetterBuilder() { return *m_firstLetterBuilder; }
     List& listBuilder() { return *m_listBuilder; }
@@ -59,7 +58,6 @@
     MultiColumn& multiColumnBuilder() { return *m_multiColumnBuilder; }
     Table& tableBuilder() { return *m_tableBuilder; }
     Ruby& rubyBuilder() { return *m_rubyBuilder; }
-    FormControls& formControlsBuilder() { return *m_formControlsBuilder; }
 
     RenderView& m_view;
 
@@ -71,7 +69,6 @@
     std::unique_ptr<MultiColumn> m_multiColumnBuilder;
     std::unique_ptr<Table> m_tableBuilder;
     std::unique_ptr<Ruby> m_rubyBuilder;
-    std::unique_ptr<FormControls> m_formControlsBuilder;
 };
 
 }

Deleted: branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp	2018-01-12 01:50:29 UTC (rev 226827)
@@ -1,65 +0,0 @@
-/*
- * Copyright (C) 2017 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "RenderTreeBuilderFormControls.h"
-
-#include "RenderButton.h"
-#include "RenderMenuList.h"
-
-namespace WebCore {
-
-RenderTreeBuilder::FormControls::FormControls(RenderTreeBuilder& builder)
-    : m_builder(builder)
-{
-}
-
-RenderBlock& RenderTreeBuilder::FormControls::createInnerRendererIfNeeded(RenderButton& button)
-{
-    auto* innerRenderer = button.innerRenderer();
-    if (innerRenderer)
-        return *innerRenderer;
-
-    auto wrapper = button.createAnonymousBlock(button.style().display());
-    innerRenderer = wrapper.get();
-    button.RenderFlexibleBox::addChild(m_builder, WTFMove(wrapper));
-    button.setInnerRenderer(*innerRenderer);
-    return *innerRenderer;
-}
-
-RenderBlock& RenderTreeBuilder::FormControls::createInnerRendererIfNeeded(RenderMenuList& menuList)
-{
-    auto* innerRenderer = menuList.innerRenderer();
-    if (innerRenderer)
-        return *innerRenderer;
-
-    auto wrapper = menuList.createAnonymousBlock();
-    innerRenderer = wrapper.get();
-    menuList.RenderFlexibleBox::addChild(m_builder, WTFMove(wrapper));
-    menuList.setInnerRenderer(*innerRenderer);
-    return *innerRenderer;
-}
-
-}

Deleted: branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h (226826 => 226827)


--- branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h	2018-01-12 01:43:06 UTC (rev 226826)
+++ branches/safari-605-branch/Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h	2018-01-12 01:50:29 UTC (rev 226827)
@@ -1,48 +0,0 @@
-/*
- * Copyright (C) 2017 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-#include "RenderTreeBuilder.h"
-
-namespace WebCore {
-
-class RenderBlock;
-class RenderButton;
-class RenderMenuList;
-
-class RenderTreeBuilder::FormControls {
-public:
-    FormControls(RenderTreeBuilder&);
-
-    RenderBlock& createInnerRendererIfNeeded(RenderButton&);
-    RenderBlock& createInnerRendererIfNeeded(RenderMenuList&);
-
-private:
-    RenderTreeBuilder& m_builder;
-};
-
-}
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to