Title: [226951] trunk/Source/WebCore
- Revision
- 226951
- Author
- [email protected]
- Date
- 2018-01-15 09:54:00 -0800 (Mon, 15 Jan 2018)
Log Message
RealtimeMediaSource should be ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=181649
Patch by Youenn Fablet <[email protected]> on 2018-01-15
Reviewed by Eric Carlson.
Difficult to write a test as this is really racy.
RealtimeIncomingVideoSourceCocoa::OnFrame is taking a reference on a background thread
to send a task to the main thread.
This requires it to be thread safe ref counted.
* platform/mediastream/RealtimeMediaSource.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (226950 => 226951)
--- trunk/Source/WebCore/ChangeLog 2018-01-15 17:36:15 UTC (rev 226950)
+++ trunk/Source/WebCore/ChangeLog 2018-01-15 17:54:00 UTC (rev 226951)
@@ -1,3 +1,17 @@
+2018-01-15 Youenn Fablet <[email protected]>
+
+ RealtimeMediaSource should be ThreadSafeRefCounted
+ https://bugs.webkit.org/show_bug.cgi?id=181649
+
+ Reviewed by Eric Carlson.
+
+ Difficult to write a test as this is really racy.
+ RealtimeIncomingVideoSourceCocoa::OnFrame is taking a reference on a background thread
+ to send a task to the main thread.
+ This requires it to be thread safe ref counted.
+
+ * platform/mediastream/RealtimeMediaSource.h:
+
2018-01-15 Philippe Normand <[email protected]>
Prevent useless MediaPlayer mute state notifications
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h (226950 => 226951)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2018-01-15 17:36:15 UTC (rev 226950)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2018-01-15 17:54:00 UTC (rev 226951)
@@ -41,7 +41,7 @@
#include "MediaSample.h"
#include "PlatformLayer.h"
#include "RealtimeMediaSourceCapabilities.h"
-#include <wtf/RefCounted.h>
+#include <wtf/ThreadSafeRefCounted.h>
#include <wtf/Vector.h>
#include <wtf/WeakPtr.h>
#include <wtf/text/WTFString.h>
@@ -62,7 +62,7 @@
struct CaptureSourceOrError;
-class WEBCORE_EXPORT RealtimeMediaSource : public RefCounted<RealtimeMediaSource> {
+class WEBCORE_EXPORT RealtimeMediaSource : public ThreadSafeRefCounted<RealtimeMediaSource> {
public:
class Observer {
public:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
