Title: [226992] trunk/Source/WebInspectorUI
Revision
226992
Author
[email protected]
Date
2018-01-16 12:20:35 -0800 (Tue, 16 Jan 2018)

Log Message

Web Inspector: Network Tab - Export HAR Context Menu not working
https://bugs.webkit.org/show_bug.cgi?id=181694
<rdar://problem/36479197>

Patch by Joseph Pecoraro <[email protected]> on 2018-01-16
Reviewed by Brian Burg.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
Ensure `this` works in the handler.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (226991 => 226992)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-01-16 19:47:57 UTC (rev 226991)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-01-16 20:20:35 UTC (rev 226992)
@@ -1,3 +1,15 @@
+2018-01-16  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Network Tab - Export HAR Context Menu not working
+        https://bugs.webkit.org/show_bug.cgi?id=181694
+        <rdar://problem/36479197>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
+        Ensure `this` works in the handler.
+
 2018-01-15  Matt Baker  <[email protected]>
 
         Web Inspector: TabBar redesign: add context menu to TabBar for toggling available tabs

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (226991 => 226992)


--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js	2018-01-16 19:47:57 UTC (rev 226991)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js	2018-01-16 20:20:35 UTC (rev 226992)
@@ -344,7 +344,7 @@
         WI.appendContextMenuItemsForSourceCode(contextMenu, entry.resource);
 
         contextMenu.appendSeparator();
-        contextMenu.appendItem(WI.UIString("Export HAR"), this._exportHAR);
+        contextMenu.appendItem(WI.UIString("Export HAR"), () => { this._exportHAR(); });
     }
 
     tableSelectedRowChanged(table, rowIndex)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to