Diff
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227013 => 227014)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-01-17 05:03:33 UTC (rev 227014)
@@ -1,3 +1,18 @@
+2018-01-16 Jason Marcell <[email protected]>
+
+ Cherry-pick r226790. rdar://problem/36568094
+
+ 2018-01-11 Youenn Fablet <[email protected]>
+
+ Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
+ https://bugs.webkit.org/show_bug.cgi?id=181480
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior.
+
+ * page/RuntimeEnabledFeatures.h: Set default value to false.
+
2018-01-12 Jason Marcell <[email protected]>
Apply patch. rdar://problem/36303061
Modified: branches/safari-605-branch/Source/WebCore/page/RuntimeEnabledFeatures.h (227013 => 227014)
--- branches/safari-605-branch/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-01-17 05:03:33 UTC (rev 227014)
@@ -277,7 +277,7 @@
#if ENABLE(WEB_RTC)
bool m_isPeerConnectionEnabled { true };
- bool m_webRTCLegacyAPIEnabled { true };
+ bool m_webRTCLegacyAPIEnabled { false };
#endif
#if ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (227013 => 227014)
--- branches/safari-605-branch/Source/WebKit/ChangeLog 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog 2018-01-17 05:03:33 UTC (rev 227014)
@@ -1,3 +1,29 @@
+2018-01-16 Jason Marcell <[email protected]>
+
+ Cherry-pick r226790. rdar://problem/36568094
+
+ 2018-01-11 Youenn Fablet <[email protected]>
+
+ Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
+ https://bugs.webkit.org/show_bug.cgi?id=181480
+
+ Reviewed by Eric Carlson.
+
+ Renaming preference to WebRTCLegacyAPIEnabled for simplification and removing it from experimental feature.
+ Set it to off by default.
+
+ * Shared/WebPreferences.yaml:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetWebRTCLegacyAPIEnabled):
+ (WKPreferencesGetWebRTCLegacyAPIEnabled):
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _webRTCLegacyAPIEnabled]):
+ (-[WKPreferences _setWebRTCLegacyAPIEnabled:]):
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::ensureNetworkProcess):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2018-01-12 Jason Marcell <[email protected]>
Cherry-pick r226838. rdar://problem/36480711
Modified: branches/safari-605-branch/Source/WebKit/Shared/WebPreferences.yaml (227013 => 227014)
--- branches/safari-605-branch/Source/WebKit/Shared/WebPreferences.yaml 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKit/Shared/WebPreferences.yaml 2018-01-17 05:03:33 UTC (rev 227014)
@@ -1103,13 +1103,12 @@
category: experimental
webcoreBinding: RuntimeEnabledFeatures
-WebRTCLegacyAPIDisabled:
+WebRTCLegacyAPIEnabled:
type: bool
- defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
- humanReadableName: "Remove Legacy WebRTC API"
- humanReadableDescription: "Remove Legacy WebRTC API"
- category: experimental
- webcoreBinding: custom
+ defaultValue: false
+ humanReadableName: "Enable Legacy WebRTC API"
+ humanReadableDescription: "Enable Legacy WebRTC API"
+ webcoreBinding: RuntimeEnabledFeatures
condition: ENABLE(WEB_RTC)
IsSecureContextAttributeEnabled:
Modified: branches/safari-605-branch/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (227013 => 227014)
--- branches/safari-605-branch/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-01-17 05:03:33 UTC (rev 227014)
@@ -1416,12 +1416,12 @@
void WKPreferencesSetWebRTCLegacyAPIEnabled(WKPreferencesRef preferencesRef, bool enabled)
{
- toImpl(preferencesRef)->setWebRTCLegacyAPIDisabled(!enabled);
+ toImpl(preferencesRef)->setWebRTCLegacyAPIEnabled(enabled);
}
bool WKPreferencesGetWebRTCLegacyAPIEnabled(WKPreferencesRef preferencesRef)
{
- return !toImpl(preferencesRef)->webRTCLegacyAPIDisabled();
+ return toImpl(preferencesRef)->webRTCLegacyAPIEnabled();
}
void WKPreferencesSetSpatialNavigationEnabled(WKPreferencesRef preferencesRef, bool enabled)
Modified: branches/safari-605-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (227013 => 227014)
--- branches/safari-605-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-01-17 05:03:33 UTC (rev 227014)
@@ -660,12 +660,12 @@
- (BOOL)_webRTCLegacyAPIEnabled
{
- return !_preferences->webRTCLegacyAPIDisabled();
+ return _preferences->webRTCLegacyAPIEnabled();
}
- (void)_setWebRTCLegacyAPIEnabled:(BOOL)enabled
{
- _preferences->setWebRTCLegacyAPIDisabled(!enabled);
+ _preferences->setWebRTCLegacyAPIEnabled(enabled);
}
- (void)_setJavaScriptCanAccessClipboard:(BOOL)_javascript_CanAccessClipboard
Modified: branches/safari-605-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp (227013 => 227014)
--- branches/safari-605-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-01-17 05:03:33 UTC (rev 227014)
@@ -3080,10 +3080,6 @@
settings.setDataDetectorTypes(static_cast<DataDetectorTypes>(store.getUInt32ValueForKey(WebPreferencesKey::dataDetectorTypesKey())));
#endif
-#if ENABLE(WEB_RTC)
- RuntimeEnabledFeatures::sharedFeatures().setWebRTCLegacyAPIEnabled(!store.getBoolValueForKey(WebPreferencesKey::webRTCLegacyAPIDisabledKey()));
-#endif
-
RuntimeEnabledFeatures::sharedFeatures().setWebAuthenticationEnabled(store.getBoolValueForKey(WebPreferencesKey::webAuthenticationEnabledKey()));
DatabaseManager::singleton().setIsAvailable(store.getBoolValueForKey(WebPreferencesKey::databasesEnabledKey()));
Modified: branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog (227013 => 227014)
--- branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog 2018-01-17 05:03:33 UTC (rev 227014)
@@ -1,3 +1,17 @@
+2018-01-16 Jason Marcell <[email protected]>
+
+ Cherry-pick r226790. rdar://problem/36568094
+
+ 2018-01-11 Youenn Fablet <[email protected]>
+
+ Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
+ https://bugs.webkit.org/show_bug.cgi?id=181480
+
+ Reviewed by Eric Carlson.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+
2018-01-12 Jason Marcell <[email protected]>
Apply patch. rdar://problem/36303061
Modified: branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (227013 => 227014)
--- branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-01-17 05:03:29 UTC (rev 227013)
+++ branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-01-17 05:03:33 UTC (rev 227014)
@@ -658,7 +658,7 @@
#endif
#if ENABLE(WEB_RTC)
[NSNumber numberWithBool:YES], WebKitPeerConnectionEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitWebRTCLegacyAPIEnabledPreferenceKey,
+ [NSNumber numberWithBool:NO], WebKitWebRTCLegacyAPIEnabledPreferenceKey,
#endif
#if ENABLE(INTERSECTION_OBSERVER)
@NO, WebKitIntersectionObserverEnabledPreferenceKey,
