Title: [227013] branches/safari-605-branch/Source/WebInspectorUI
- Revision
- 227013
- Author
- [email protected]
- Date
- 2018-01-16 21:03:29 -0800 (Tue, 16 Jan 2018)
Log Message
Cherry-pick r226765. rdar://problem/36568045
Modified Paths
Diff
Modified: branches/safari-605-branch/Source/WebInspectorUI/ChangeLog (227012 => 227013)
--- branches/safari-605-branch/Source/WebInspectorUI/ChangeLog 2018-01-17 05:03:26 UTC (rev 227012)
+++ branches/safari-605-branch/Source/WebInspectorUI/ChangeLog 2018-01-17 05:03:29 UTC (rev 227013)
@@ -1,5 +1,25 @@
2018-01-16 Jason Marcell <[email protected]>
+ Cherry-pick r226765. rdar://problem/36568045
+
+ 2018-01-10 Joseph Pecoraro <[email protected]>
+
+ REGRESSION(r218975): Web Inspector: Add back NavigationSidebarPanel initialization parameter used by SearchSidebarPanel (top overflow shadow)
+ https://bugs.webkit.org/show_bug.cgi?id=181518
+ <rdar://problem/36427197>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/NavigationSidebarPanel.css:
+ (.sidebar > .panel.navigation > .overflow-shadow.top):
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WI.NavigationSidebarPanel):
+ Add back the initialization parameter still used by SearchSidebarPanel
+ and add back its implementation. There were still references to
+ dynamically update _topOverflowShadowElement in NavigationSidebarPanel.
+
+2018-01-16 Jason Marcell <[email protected]>
+
Cherry-pick r226674. rdar://problem/36568078
2018-01-09 Joseph Pecoraro <[email protected]>
Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.css (227012 => 227013)
--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.css 2018-01-17 05:03:26 UTC (rev 227012)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.css 2018-01-17 05:03:29 UTC (rev 227013)
@@ -47,3 +47,8 @@
border-bottom: 1px solid var(--border-color);
}
+
+.sidebar > .panel.navigation > .overflow-shadow.top {
+ top: calc(var(--navigation-bar-height) - 1px);
+ bottom: initial;
+}
Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (227012 => 227013)
--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2018-01-17 05:03:26 UTC (rev 227012)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2018-01-17 05:03:29 UTC (rev 227013)
@@ -25,7 +25,7 @@
WI.NavigationSidebarPanel = class NavigationSidebarPanel extends WI.SidebarPanel
{
- constructor(identifier, displayName, shouldAutoPruneStaleTopLevelResourceTreeElements)
+ constructor(identifier, displayName, shouldAutoPruneStaleTopLevelResourceTreeElements, wantsTopOverflowShadow)
{
super(identifier, displayName);
@@ -44,6 +44,11 @@
this._bottomOverflowShadowElement.className = WI.NavigationSidebarPanel.OverflowShadowElementStyleClassName;
this.element.appendChild(this._bottomOverflowShadowElement);
+ if (wantsTopOverflowShadow) {
+ this._topOverflowShadowElement = this.element.appendChild(document.createElement("div"));
+ this._topOverflowShadowElement.classList.add(WI.NavigationSidebarPanel.OverflowShadowElementStyleClassName, "top");
+ }
+
this._boundUpdateContentOverflowShadowVisibility = this.soon._updateContentOverflowShadowVisibility;
window.addEventListener("resize", this._boundUpdateContentOverflowShadowVisibility);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
