Diff
Modified: trunk/Source/WebCore/ChangeLog (100634 => 100635)
--- trunk/Source/WebCore/ChangeLog 2011-11-17 17:09:19 UTC (rev 100634)
+++ trunk/Source/WebCore/ChangeLog 2011-11-17 17:14:17 UTC (rev 100635)
@@ -1,3 +1,15 @@
+2011-11-17 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Remove onlineDetectionEnabled from Preferences
+ https://bugs.webkit.org/show_bug.cgi?id=72617
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ApplicationCacheItemsView.js:
+ (WebInspector.ApplicationCacheItemsView):
+ (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
+ * inspector/front-end/Settings.js:
+
2011-11-17 Ken Buchanan <[email protected]>
Crash from nested tables with generated content
Modified: trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js (100634 => 100635)
--- trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js 2011-11-17 17:09:19 UTC (rev 100634)
+++ trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js 2011-11-17 17:14:17 UTC (rev 100635)
@@ -41,14 +41,12 @@
this.deleteButton.visible = false;
this.deleteButton.addEventListener("click", this._deleteButtonClicked, this);
- if (Preferences.onlineDetectionEnabled) {
- this.connectivityIcon = document.createElement("img");
- this.connectivityIcon.className = "storage-application-cache-connectivity-icon";
- this.connectivityIcon.src = ""
- this.connectivityMessage = document.createElement("span");
- this.connectivityMessage.className = "storage-application-cache-connectivity";
- this.connectivityMessage.textContent = "";
- }
+ this.connectivityIcon = document.createElement("img");
+ this.connectivityIcon.className = "storage-application-cache-connectivity-icon";
+ this.connectivityIcon.src = ""
+ this.connectivityMessage = document.createElement("span");
+ this.connectivityMessage.className = "storage-application-cache-connectivity";
+ this.connectivityMessage.textContent = "";
this.divider = document.createElement("span");
this.divider.className = "status-bar-item status-bar-divider";
@@ -70,29 +68,21 @@
// FIXME: Status bar items don't work well enough yet, so they are being hidden.
// http://webkit.org/b/41637 Web Inspector: Give Semantics to "Refresh" and "Delete" Buttons in ApplicationCache DataGrid
+ // http://webkit.org/b/72618 Web Inspector: ApplicationCache view should show navigator.onLine indicator.
this.deleteButton.element.style.display = "none";
- if (Preferences.onlineDetectionEnabled) {
- this.connectivityIcon.style.display = "none";
- this.connectivityMessage.style.display = "none";
- }
+ this.connectivityIcon.style.display = "none";
+ this.connectivityMessage.style.display = "none";
this.divider.style.display = "none";
}
WebInspector.ApplicationCacheItemsView.prototype = {
get statusBarItems()
{
- if (Preferences.onlineDetectionEnabled) {
- return [
- this.deleteButton.element,
- this.connectivityIcon, this.connectivityMessage, this.divider,
- this.statusIcon, this.statusMessage
- ];
- } else {
- return [
- this.deleteButton.element, this.divider,
- this.statusIcon, this.statusMessage
- ];
- }
+ return [
+ this.deleteButton.element,
+ this.connectivityIcon, this.connectivityMessage, this.divider,
+ this.statusIcon, this.statusMessage
+ ];
},
wasShown: function()
@@ -152,14 +142,12 @@
*/
updateNetworkState: function(isNowOnline)
{
- if (Preferences.onlineDetectionEnabled) {
- if (isNowOnline) {
- this.connectivityIcon.src = ""
- this.connectivityMessage.textContent = WebInspector.UIString("Online");
- } else {
- this.connectivityIcon.src = ""
- this.connectivityMessage.textContent = WebInspector.UIString("Offline");
- }
+ if (isNowOnline) {
+ this.connectivityIcon.src = ""
+ this.connectivityMessage.textContent = WebInspector.UIString("Online");
+ } else {
+ this.connectivityIcon.src = ""
+ this.connectivityMessage.textContent = WebInspector.UIString("Offline");
}
},
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (100634 => 100635)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-17 17:09:19 UTC (rev 100634)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-17 17:14:17 UTC (rev 100635)
@@ -41,7 +41,6 @@
showColorNicknames: true,
debuggerAlwaysEnabled: false,
profilerAlwaysEnabled: false,
- onlineDetectionEnabled: true,
nativeInstrumentationEnabled: false,
useDataURLForResourceImageIcons: true,
showTimingTab: false,
Modified: trunk/Source/WebKit/chromium/ChangeLog (100634 => 100635)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-17 17:09:19 UTC (rev 100634)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-17 17:14:17 UTC (rev 100635)
@@ -1,3 +1,12 @@
+2011-11-17 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Remove onlineDetectionEnabled from Preferences
+ https://bugs.webkit.org/show_bug.cgi?id=72617
+
+ Reviewed by Pavel Feldman.
+
+ * src/js/DevTools.js:
+
2011-11-17 Kenichi Ishibashi <[email protected]>
[chromium] don't call fontconfig twice in complex text path
Modified: trunk/Source/WebKit/chromium/src/js/DevTools.js (100634 => 100635)
--- trunk/Source/WebKit/chromium/src/js/DevTools.js 2011-11-17 17:09:19 UTC (rev 100634)
+++ trunk/Source/WebKit/chromium/src/js/DevTools.js 2011-11-17 17:14:17 UTC (rev 100635)
@@ -40,7 +40,6 @@
Preferences.detailedHeapProfiles = true;
Preferences.debuggerAlwaysEnabled = true;
Preferences.profilerAlwaysEnabled = true;
- Preferences._onlineDetectionEnabled_ = false;
Preferences.nativeInstrumentationEnabled = true;
Preferences.fileSystemEnabled = false;
Preferences.showTimingTab = true;
