Title: [227039] branches/safari-605-branch/Source/WebInspectorUI
- Revision
- 227039
- Author
- [email protected]
- Date
- 2018-01-16 21:04:57 -0800 (Tue, 16 Jan 2018)
Log Message
Cherry-pick r226996. rdar://problem/36568089
Modified Paths
Diff
Modified: branches/safari-605-branch/Source/WebInspectorUI/ChangeLog (227038 => 227039)
--- branches/safari-605-branch/Source/WebInspectorUI/ChangeLog 2018-01-17 05:04:55 UTC (rev 227038)
+++ branches/safari-605-branch/Source/WebInspectorUI/ChangeLog 2018-01-17 05:04:57 UTC (rev 227039)
@@ -1,5 +1,20 @@
2018-01-16 Jason Marcell <[email protected]>
+ Cherry-pick r226996. rdar://problem/36568089
+
+ 2018-01-16 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Styles: pressing down key should select first item from completion list when focusing on empty value
+ https://bugs.webkit.org/show_bug.cgi?id=181633
+ <rdar://problem/36501797>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SpreadsheetTextField.js:
+ (WI.SpreadsheetTextField.prototype._updateCompletions):
+
+2018-01-16 Jason Marcell <[email protected]>
+
Cherry-pick r226994. rdar://problem/36568074
2018-01-16 Nikita Vasilyev <[email protected]>
Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js (227038 => 227039)
--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-01-17 05:04:55 UTC (rev 227038)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-01-17 05:04:57 UTC (rev 227039)
@@ -381,11 +381,11 @@
this._suggestionsView.show(caretRect);
}
- // Select first item and call completionSuggestionsSelectedCompletion.
this._suggestionsView.selectedIndex = NaN;
- this._suggestionsView.selectNext();
-
- if (!completionPrefix)
+ if (completionPrefix) {
+ // Select first item and call completionSuggestionsSelectedCompletion.
+ this._suggestionsView.selectNext();
+ } else
this.suggestionHint = "";
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
