Title: [227102] trunk/Source/WebCore
- Revision
- 227102
- Author
- [email protected]
- Date
- 2018-01-17 17:47:44 -0800 (Wed, 17 Jan 2018)
Log Message
Remove linked-on test for Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=181770
Reviewed by Eric Carlson.
Source/WebCore:
Remove a very old linked-on-or-after test.
* platform/graphics/ca/GraphicsLayerCA.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227101 => 227102)
--- trunk/Source/WebCore/ChangeLog 2018-01-18 01:31:36 UTC (rev 227101)
+++ trunk/Source/WebCore/ChangeLog 2018-01-18 01:47:44 UTC (rev 227102)
@@ -1,3 +1,14 @@
+2018-01-17 Dean Jackson <[email protected]>
+
+ Remove linked-on test for Snow Leopard
+ https://bugs.webkit.org/show_bug.cgi?id=181770
+
+ Reviewed by Eric Carlson.
+
+ Remove a very old linked-on-or-after test.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+
2018-01-17 Matt Lewis <[email protected]>
Unreviewed, rolling out r227098.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (227101 => 227102)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2018-01-18 01:31:36 UTC (rev 227101)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2018-01-18 01:47:44 UTC (rev 227102)
@@ -3009,35 +3009,16 @@
bool isMatrixAnimation = listIndex < 0;
int numAnimations = isMatrixAnimation ? 1 : operations->size();
-#if PLATFORM(IOS)
- bool reverseAnimationList = false;
+#if !PLATFORM(WIN)
+ for (int animationIndex = 0; animationIndex < numAnimations; ++animationIndex) {
#else
- bool reverseAnimationList = true;
-#if !PLATFORM(WIN)
- // Old versions of Core Animation apply animations in reverse order (<rdar://problem/7095638>) so we need to flip the list.
- // to be non-additive. For binary compatibility, the current version of Core Animation preserves this behavior for applications linked
- // on or before Snow Leopard.
- // FIXME: This fix has not been added to QuartzCore on Windows yet (<rdar://problem/9112233>) so we expect the
- // reversed animation behavior
- static bool executableWasLinkedOnOrBeforeSnowLeopard = !_CFExecutableLinkedOnOrAfter(CFSystemVersionLion);
- if (!executableWasLinkedOnOrBeforeSnowLeopard)
- reverseAnimationList = false;
+ // QuartzCore on Windows expects animation lists to be applied in reverse order (<rdar://problem/9112233>).
+ for (int animationIndex = numAnimations - 1; animationIndex >= 0; --animationIndex) {
#endif
-#endif // PLATFORM(IOS)
- if (reverseAnimationList) {
- for (int animationIndex = numAnimations - 1; animationIndex >= 0; --animationIndex) {
- if (!appendToUncommittedAnimations(valueList, operations, animation, animationName, boxSize, animationIndex, timeOffset, isMatrixAnimation)) {
- validMatrices = false;
- break;
- }
+ if (!appendToUncommittedAnimations(valueList, operations, animation, animationName, boxSize, animationIndex, timeOffset, isMatrixAnimation)) {
+ validMatrices = false;
+ break;
}
- } else {
- for (int animationIndex = 0; animationIndex < numAnimations; ++animationIndex) {
- if (!appendToUncommittedAnimations(valueList, operations, animation, animationName, boxSize, animationIndex, timeOffset, isMatrixAnimation)) {
- validMatrices = false;
- break;
- }
- }
}
return validMatrices;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
