Skip to site navigation (Press enter)

[webkit-changes] [227119] branches/safari-605-branch/Source/WebInspectorUI

jmarcell Wed, 17 Jan 2018 21:48:24 -0800

Title: [227119] branches/safari-605-branch/Source/WebInspectorUI

Revision: 227119
Author: [email protected]
Date: 2018-01-17 21:48:02 -0800 (Wed, 17 Jan 2018)

Log Message

Cherry-pick r227078. rdar://problem/36597996


Modified Paths

branches/safari-605-branch/Source/WebInspectorUI/ChangeLog
branches/safari-605-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsSidebarPanel.js

Diff

Modified: branches/safari-605-branch/Source/WebInspectorUI/ChangeLog (227118 => 227119)


--- branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-01-18 05:47:59 UTC (rev 227118)
+++ branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-01-18 05:48:02 UTC (rev 227119)
@@ -1,3 +1,24 @@
+2018-01-17  Jason Marcell  <[email protected]>
+
+        Cherry-pick r227078. rdar://problem/36597996
+
+    2018-01-17  Joseph Pecoraro  <[email protected]>
+
+            Web Inspector: Add back localized strings for Styles sidebar panels
+            https://bugs.webkit.org/show_bug.cgi?id=181748
+            <rdar://problem/36583184>
+
+            Reviewed by Brian Burg.
+
+            * Localizations/en.lproj/localizedStrings.js:
+            * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
+            (WI.ComputedStyleDetailsSidebarPanel):
+            * UserInterface/Views/RulesStyleDetailsSidebarPanel.js:
+            (WI.RulesStyleDetailsSidebarPanel):
+            * UserInterface/Views/VisualStyleDetailsSidebarPanel.js:
+            (WI.VisualStyleDetailsSidebarPanel):
+            Add back localized strings for panel titles lost in r225547.
+
 2018-01-16  Jason Marcell  <[email protected]>
 
         Cherry-pick r226995. rdar://problem/36568070

Modified: branches/safari-605-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (227118 => 227119)


--- branches/safari-605-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2018-01-18 05:47:59 UTC (rev 227118)
+++ branches/safari-605-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2018-01-18 05:48:02 UTC (rev 227119)
@@ -226,6 +226,7 @@
 localizedStrings["Compressed"] = "Compressed";
 localizedStrings["Compression"] = "Compression";
 localizedStrings["Compression:"] = "Compression:";
+localizedStrings["Computed"] = "Computed";
 localizedStrings["Condition"] = "Condition";
 localizedStrings["Conditional _expression_"] = "Conditional _expression_";
 localizedStrings["Connecting"] = "Connecting";
@@ -920,6 +921,7 @@
 localizedStrings["Style Attribute"] = "Style Attribute";
 localizedStrings["Style Rules"] = "Style Rules";
 localizedStrings["Style rule"] = "Style rule";
+localizedStrings["Styles"] = "Styles";
 localizedStrings["Styles Invalidated"] = "Styles Invalidated";
 localizedStrings["Styles Recalculated"] = "Styles Recalculated";
 localizedStrings["Styles Sidebar:"] = "Styles Sidebar:";
@@ -1022,6 +1024,7 @@
 localizedStrings["View variable value"] = "View variable value";
 localizedStrings["Visibility"] = "Visibility";
 localizedStrings["Visible"] = "Visible";
+localizedStrings["Visual"] = "Visual";
 localizedStrings["Waiting"] = "Waiting";
 localizedStrings["Waiting for canvas contexts created by script or CSS."] = "Waiting for canvas contexts created by script or CSS.";
 localizedStrings["Waiting for frames…"] = "Waiting for frames…";

Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js (227118 => 227119)


--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js	2018-01-18 05:47:59 UTC (rev 227118)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js	2018-01-18 05:48:02 UTC (rev 227119)
@@ -27,6 +27,6 @@
 {
     constructor()
     {
-        super("style-computed", "Computed", WI.ComputedStyleDetailsPanel);
+        super("style-computed", WI.UIString("Computed"), WI.ComputedStyleDetailsPanel);
     }
 };

Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js (227118 => 227119)


--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js	2018-01-18 05:47:59 UTC (rev 227118)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js	2018-01-18 05:48:02 UTC (rev 227119)
@@ -34,6 +34,6 @@
         else
             rulesStyleDetailsPanelConstructor = WI.SpreadsheetRulesStyleDetailsPanel;
 
-        super("style-rules", "Styles", rulesStyleDetailsPanelConstructor);
+        super("style-rules", WI.UIString("Styles"), rulesStyleDetailsPanelConstructor);
     }
 };

Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsSidebarPanel.js (227118 => 227119)


--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsSidebarPanel.js	2018-01-18 05:47:59 UTC (rev 227118)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsSidebarPanel.js	2018-01-18 05:48:02 UTC (rev 227119)
@@ -27,6 +27,6 @@
 {
     constructor()
     {
-        super("style-visual", "Visual", WI.VisualStyleDetailsPanel);
+        super("style-visual", WI.UIString("Visual"), WI.VisualStyleDetailsPanel);
     }
 };

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes