Title: [227205] trunk/Source
- Revision
- 227205
- Author
- [email protected]
- Date
- 2018-01-19 09:46:06 -0800 (Fri, 19 Jan 2018)
Log Message
Remove unused WebViewPrivate _allowCookies
https://bugs.webkit.org/show_bug.cgi?id=181812
Patch by Alex Christensen <[email protected]> on 2018-01-19
Reviewed by Tim Horton.
Source/WebCore:
This SPI was in the original iOS upstreaming and has not been used in many years.
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setDefaultAllowCookies): Deleted.
(WebCore::ResourceRequestBase::defaultAllowCookies): Deleted.
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
Source/WebKitLegacy/mac:
* WebView/WebView.mm:
(+[WebView _setAllowCookies:]): Deleted.
(+[WebView _allowCookies]): Deleted.
* WebView/WebViewPrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227204 => 227205)
--- trunk/Source/WebCore/ChangeLog 2018-01-19 17:45:06 UTC (rev 227204)
+++ trunk/Source/WebCore/ChangeLog 2018-01-19 17:46:06 UTC (rev 227205)
@@ -1,3 +1,18 @@
+2018-01-19 Alex Christensen <[email protected]>
+
+ Remove unused WebViewPrivate _allowCookies
+ https://bugs.webkit.org/show_bug.cgi?id=181812
+
+ Reviewed by Tim Horton.
+
+ This SPI was in the original iOS upstreaming and has not been used in many years.
+
+ * platform/network/ResourceRequestBase.cpp:
+ (WebCore::ResourceRequestBase::setDefaultAllowCookies): Deleted.
+ (WebCore::ResourceRequestBase::defaultAllowCookies): Deleted.
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::ResourceRequestBase):
+
2018-01-18 Brady Eidson <[email protected]>
Make in-process MessagePorts be (mostly) asynchronous
Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp (227204 => 227205)
--- trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp 2018-01-19 17:45:06 UTC (rev 227204)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp 2018-01-19 17:46:06 UTC (rev 227205)
@@ -41,10 +41,6 @@
double ResourceRequestBase::s_defaultTimeoutInterval = 0;
#endif
-#if PLATFORM(IOS)
-bool ResourceRequestBase::s_defaultAllowCookies = true;
-#endif
-
inline const ResourceRequest& ResourceRequestBase::asResourceRequest() const
{
return *static_cast<const ResourceRequest*>(this);
@@ -644,18 +640,6 @@
}
#endif
-#if PLATFORM(IOS)
-void ResourceRequestBase::setDefaultAllowCookies(bool allowCookies)
-{
- s_defaultAllowCookies = allowCookies;
-}
-
-bool ResourceRequestBase::defaultAllowCookies()
-{
- return s_defaultAllowCookies;
-}
-#endif
-
void ResourceRequestBase::setCachePartition(const String& cachePartition)
{
#if ENABLE(CACHE_PARTITIONING)
Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.h (227204 => 227205)
--- trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2018-01-19 17:45:06 UTC (rev 227204)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2018-01-19 17:46:06 UTC (rev 227205)
@@ -168,11 +168,6 @@
WEBCORE_EXPORT static double defaultTimeoutInterval(); // May return 0 when using platform default.
WEBCORE_EXPORT static void setDefaultTimeoutInterval(double);
-#if PLATFORM(IOS)
- WEBCORE_EXPORT static bool defaultAllowCookies();
- WEBCORE_EXPORT static void setDefaultAllowCookies(bool);
-#endif
-
WEBCORE_EXPORT static bool equal(const ResourceRequest&, const ResourceRequest&);
protected:
@@ -188,11 +183,7 @@
, m_timeoutInterval(s_defaultTimeoutInterval)
, m_httpMethod(ASCIILiteral("GET"))
, m_cachePolicy(policy)
-#if !PLATFORM(IOS)
, m_allowCookies(true)
-#else
- , m_allowCookies(ResourceRequestBase::defaultAllowCookies())
-#endif
, m_resourceRequestUpdated(true)
, m_resourceRequestBodyUpdated(true)
{
@@ -230,9 +221,6 @@
const ResourceRequest& asResourceRequest() const;
WEBCORE_EXPORT static double s_defaultTimeoutInterval;
-#if PLATFORM(IOS)
- static bool s_defaultAllowCookies;
-#endif
};
bool equalIgnoringHeaderFields(const ResourceRequestBase&, const ResourceRequestBase&);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (227204 => 227205)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-01-19 17:45:06 UTC (rev 227204)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-01-19 17:46:06 UTC (rev 227205)
@@ -1,3 +1,15 @@
+2018-01-19 Alex Christensen <[email protected]>
+
+ Remove unused WebViewPrivate _allowCookies
+ https://bugs.webkit.org/show_bug.cgi?id=181812
+
+ Reviewed by Tim Horton.
+
+ * WebView/WebView.mm:
+ (+[WebView _setAllowCookies:]): Deleted.
+ (+[WebView _allowCookies]): Deleted.
+ * WebView/WebViewPrivate.h:
+
2018-01-18 Alexey Proskuryakov <[email protected]>
Build fix, remove a call to -[NSWindow setOneShot:]
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (227204 => 227205)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-01-19 17:45:06 UTC (rev 227204)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-01-19 17:46:06 UTC (rev 227205)
@@ -2150,16 +2150,6 @@
webResourceLoadScheduler().resumePendingRequests();
}
-+ (void)_setAllowCookies:(BOOL)allow
-{
- ResourceRequestBase::setDefaultAllowCookies(allow);
-}
-
-+ (BOOL)_allowCookies
-{
- return ResourceRequestBase::defaultAllowCookies();
-}
-
+ (BOOL)_isUnderMemoryPressure
{
return MemoryPressureHandler::singleton().isUnderMemoryPressure();
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h (227204 => 227205)
--- trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h 2018-01-19 17:45:06 UTC (rev 227204)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h 2018-01-19 17:46:06 UTC (rev 227205)
@@ -466,8 +466,6 @@
- (void)_setResourceLoadSchedulerSuspended:(BOOL)suspend;
+ (void)_setTileCacheLayerPoolCapacity:(unsigned)capacity;
-+ (void)_setAllowCookies:(BOOL)allow;
-+ (BOOL)_allowCookies;
+ (void)_releaseMemoryNow;
- (void)_replaceCurrentHistoryItem:(WebHistoryItem *)item;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
