Diff
Modified: trunk/Source/WebCore/ChangeLog (227213 => 227214)
--- trunk/Source/WebCore/ChangeLog 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebCore/ChangeLog 2018-01-19 18:32:00 UTC (rev 227214)
@@ -1,3 +1,13 @@
+2018-01-19 Daniel Bates <[email protected]>
+
+ Fix misspelling; substitute willDetachRenderer for willDetatchRenderer.
+
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::willDetachRenderers):
+ * plugins/PluginViewBase.h:
+ (WebCore::PluginViewBase::willDetachRenderer):
+ (WebCore::PluginViewBase::willDetatchRenderer): Deleted.
+
2018-01-19 Jonathan Bedard <[email protected]>
Unreviewed build fix, remove unused lambda captures.
Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (227213 => 227214)
--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2018-01-19 18:32:00 UTC (rev 227214)
@@ -233,7 +233,7 @@
{
auto widget = makeRefPtr(pluginWidget(PluginLoadingPolicy::DoNotLoad));
if (is<PluginViewBase>(widget))
- downcast<PluginViewBase>(*widget).willDetatchRenderer();
+ downcast<PluginViewBase>(*widget).willDetachRenderer();
HTMLPlugInElement::willDetachRenderers();
}
Modified: trunk/Source/WebCore/plugins/PluginViewBase.h (227213 => 227214)
--- trunk/Source/WebCore/plugins/PluginViewBase.h 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebCore/plugins/PluginViewBase.h 2018-01-19 18:32:00 UTC (rev 227214)
@@ -85,7 +85,7 @@
virtual RefPtr<JSC::Bindings::Instance> bindingInstance() { return nullptr; }
- virtual void willDetatchRenderer() { }
+ virtual void willDetachRenderer() { }
#if PLATFORM(COCOA)
virtual id accessibilityAssociatedPluginParentForElement(Element*) const { return nullptr; }
Modified: trunk/Source/WebKit/ChangeLog (227213 => 227214)
--- trunk/Source/WebKit/ChangeLog 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebKit/ChangeLog 2018-01-19 18:32:00 UTC (rev 227214)
@@ -1,3 +1,19 @@
+2018-01-19 Daniel Bates <[email protected]>
+
+ Fix misspelling; substitute willDetachRenderer for willDetatchRenderer.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.h:
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::willDetachRenderer):
+ (WebKit::PDFPlugin::willDetatchRenderer): Deleted.
+ * WebProcess/Plugins/Plugin.h:
+ (WebKit::Plugin::willDetachRenderer):
+ (WebKit::Plugin::willDetatchRenderer): Deleted.
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::willDetachRenderer):
+ (WebKit::PluginView::willDetatchRenderer): Deleted.
+ * WebProcess/Plugins/PluginView.h:
+
2018-01-19 Zach Li <[email protected]>
Expose Safe Browsing SPI
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h (227213 => 227214)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h 2018-01-19 18:32:00 UTC (rev 227214)
@@ -169,7 +169,7 @@
bool getFormValue(String& formValue) final { return false; }
bool handleScroll(WebCore::ScrollDirection, WebCore::ScrollGranularity) final;
RefPtr<WebCore::SharedBuffer> liveResourceData() const final;
- void willDetatchRenderer() final;
+ void willDetachRenderer() final;
bool pluginHandlesContentOffsetForAccessibilityHitTest() const final;
bool isBeingAsynchronouslyInitialized() const final { return false; }
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (227213 => 227214)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2018-01-19 18:32:00 UTC (rev 227214)
@@ -1162,7 +1162,7 @@
return true;
}
-void PDFPlugin::willDetatchRenderer()
+void PDFPlugin::willDetachRenderer()
{
if (webFrame()) {
if (FrameView* frameView = webFrame()->coreFrame()->view())
Modified: trunk/Source/WebKit/WebProcess/Plugins/Plugin.h (227213 => 227214)
--- trunk/Source/WebKit/WebProcess/Plugins/Plugin.h 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebKit/WebProcess/Plugins/Plugin.h 2018-01-19 18:32:00 UTC (rev 227214)
@@ -300,7 +300,7 @@
virtual bool requiresUnifiedScaleFactor() const { return false; }
- virtual void willDetatchRenderer() { }
+ virtual void willDetachRenderer() { }
virtual bool pluginHandlesContentOffsetForAccessibilityHitTest() const { return false; }
Modified: trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp (227213 => 227214)
--- trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp 2018-01-19 18:32:00 UTC (rev 227214)
@@ -992,12 +992,12 @@
return m_pluginElement->displayState() < HTMLPlugInElement::Restarting && !m_plugin->supportsSnapshotting();
}
-void PluginView::willDetatchRenderer()
+void PluginView::willDetachRenderer()
{
if (!m_isInitialized || !m_plugin)
return;
- m_plugin->willDetatchRenderer();
+ m_plugin->willDetachRenderer();
}
RefPtr<SharedBuffer> PluginView::liveResourceData() const
Modified: trunk/Source/WebKit/WebProcess/Plugins/PluginView.h (227213 => 227214)
--- trunk/Source/WebKit/WebProcess/Plugins/PluginView.h 2018-01-19 18:12:45 UTC (rev 227213)
+++ trunk/Source/WebKit/WebProcess/Plugins/PluginView.h 2018-01-19 18:32:00 UTC (rev 227214)
@@ -167,7 +167,7 @@
void beginSnapshottingRunningPlugin() override;
bool shouldAllowNavigationFromDrags() const override;
bool shouldNotAddLayer() const override;
- void willDetatchRenderer() override;
+ void willDetachRenderer() override;
// WebCore::Widget
void setFrameRect(const WebCore::IntRect&) override;
