Title: [227243] trunk/Source/WebInspectorUI
- Revision
- 227243
- Author
- [email protected]
- Date
- 2018-01-19 15:01:11 -0800 (Fri, 19 Jan 2018)
Log Message
Web Inspector: Canvas Tab: Multiple "waiting for frames" messages displayed
https://bugs.webkit.org/show_bug.cgi?id=181865
<rdar://problem/36664737>
Reviewed by Devin Rousso.
* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype._recordingStarted):
(WI.CanvasContentView.prototype._recordingStopped):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (227242 => 227243)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-01-19 22:58:48 UTC (rev 227242)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-01-19 23:01:11 UTC (rev 227243)
@@ -1,3 +1,15 @@
+2018-01-19 Matt Baker <[email protected]>
+
+ Web Inspector: Canvas Tab: Multiple "waiting for frames" messages displayed
+ https://bugs.webkit.org/show_bug.cgi?id=181865
+ <rdar://problem/36664737>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/CanvasContentView.js:
+ (WI.CanvasContentView.prototype._recordingStarted):
+ (WI.CanvasContentView.prototype._recordingStopped):
+
2018-01-19 Nikita Vasilyev <[email protected]>
Web Inspector: Styles Redesign: tabbing on commented out property throws exception
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js (227242 => 227243)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2018-01-19 22:58:48 UTC (rev 227242)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2018-01-19 23:01:11 UTC (rev 227243)
@@ -263,6 +263,9 @@
{
this._updateRecordNavigationItem();
+ if (!this.representedObject.isRecording)
+ return;
+
if (!this._recordingProgressElement) {
this._recordingProgressElement = this._previewContainerElement.insertAdjacentElement("beforebegin", document.createElement("div"));
this._recordingProgressElement.className = "progress";
@@ -297,13 +300,16 @@
this._updateRecordNavigationItem();
let {canvas, recording} = event.data;
- if (canvas !== this.representedObject || !recording)
+ if (canvas !== this.representedObject)
return;
- this._addRecording(recording);
+ if (recording)
+ this._addRecording(recording);
- this._recordingProgressElement.remove();
- this._recordingProgressElement = null;
+ if (this._recordingProgressElement) {
+ this._recordingProgressElement.remove();
+ this._recordingProgressElement = null;
+ }
}
_handleRecordingSelectElementChange(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
