Title: [227429] trunk/Source/WebKit
- Revision
- 227429
- Author
- [email protected]
- Date
- 2018-01-23 12:08:36 -0800 (Tue, 23 Jan 2018)
Log Message
Web Inspector: Window resizing is broken after detaching to separate window
https://bugs.webkit.org/show_bug.cgi?id=181992
<rdar://problem/36714840>
Patch by Joseph Pecoraro <[email protected]> on 2018-01-23
Reviewed by Brian Burg.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDetach):
Restore the inspector view's autoresizingMask to the initial value
that works with a detached window. This gets changed when the view
gets attached to bottom/side, so we need to revert it on detaching.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (227428 => 227429)
--- trunk/Source/WebKit/ChangeLog 2018-01-23 20:03:58 UTC (rev 227428)
+++ trunk/Source/WebKit/ChangeLog 2018-01-23 20:08:36 UTC (rev 227429)
@@ -1,3 +1,17 @@
+2018-01-23 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Window resizing is broken after detaching to separate window
+ https://bugs.webkit.org/show_bug.cgi?id=181992
+ <rdar://problem/36714840>
+
+ Reviewed by Brian Burg.
+
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (WebKit::WebInspectorProxy::platformDetach):
+ Restore the inspector view's autoresizingMask to the initial value
+ that works with a detached window. This gets changed when the view
+ gets attached to bottom/side, so we need to revert it on detaching.
+
2018-01-23 Brady Eidson <[email protected]>
Allow passing MessagePorts across processes (e.g. ServiceWorkers).
Modified: trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm (227428 => 227429)
--- trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm 2018-01-23 20:03:58 UTC (rev 227428)
+++ trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm 2018-01-23 20:08:36 UTC (rev 227429)
@@ -607,6 +607,8 @@
[inspectorView removeFromSuperview];
+ [inspectorView setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
+
// Make sure that we size the inspected view's frame after detaching so that it takes up the space that the
// attached inspector used to. Preserve the top position of the inspected view so banners in Safari still work.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
