Title: [100672] trunk/Source/_javascript_Core
- Revision
- 100672
- Author
- [email protected]
- Date
- 2011-11-17 14:04:07 -0800 (Thu, 17 Nov 2011)
Log Message
Add finalizer to JSActivation
https://bugs.webkit.org/show_bug.cgi?id=72575
Reviewed by Geoffrey Garen.
* runtime/JSActivation.cpp:
(JSC::JSActivation::finishCreation): Attach finalize function to objects during creation.
(JSC::JSActivation::finalize):
* runtime/JSActivation.h: Replaced virtual destructor with static finalize function.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100671 => 100672)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-17 22:03:25 UTC (rev 100671)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-17 22:04:07 UTC (rev 100672)
@@ -1,3 +1,15 @@
+2011-11-17 Mark Hahnenberg <[email protected]>
+
+ Add finalizer to JSActivation
+ https://bugs.webkit.org/show_bug.cgi?id=72575
+
+ Reviewed by Geoffrey Garen.
+
+ * runtime/JSActivation.cpp:
+ (JSC::JSActivation::finishCreation): Attach finalize function to objects during creation.
+ (JSC::JSActivation::finalize):
+ * runtime/JSActivation.h: Replaced virtual destructor with static finalize function.
+
2011-11-15 Filip Pizlo <[email protected]>
Code block jettisoning should be part of the GC's transitive closure
Modified: trunk/Source/_javascript_Core/runtime/JSActivation.cpp (100671 => 100672)
--- trunk/Source/_javascript_Core/runtime/JSActivation.cpp 2011-11-17 22:03:25 UTC (rev 100671)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.cpp 2011-11-17 22:04:07 UTC (rev 100672)
@@ -56,11 +56,12 @@
// We have to manually ref and deref the symbol table as JSVariableObject
// doesn't know about SharedSymbolTable
static_cast<SharedSymbolTable*>(m_symbolTable)->ref();
+ callFrame->globalData().heap.addFinalizer(this, &finalize);
}
-JSActivation::~JSActivation()
+void JSActivation::finalize(JSCell* cell)
{
- static_cast<SharedSymbolTable*>(m_symbolTable)->deref();
+ static_cast<SharedSymbolTable*>(jsCast<JSActivation*>(cell)->m_symbolTable)->deref();
}
void JSActivation::visitChildren(JSCell* cell, SlotVisitor& visitor)
Modified: trunk/Source/_javascript_Core/runtime/JSActivation.h (100671 => 100672)
--- trunk/Source/_javascript_Core/runtime/JSActivation.h 2011-11-17 22:03:25 UTC (rev 100671)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.h 2011-11-17 22:04:07 UTC (rev 100672)
@@ -53,7 +53,7 @@
return activation;
}
- virtual ~JSActivation();
+ static void finalize(JSCell*);
static void visitChildren(JSCell*, SlotVisitor&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
