Title: [227504] releases/WebKitGTK/webkit-2.18/Tools
- Revision
- 227504
- Author
- [email protected]
- Date
- 2018-01-24 02:02:19 -0800 (Wed, 24 Jan 2018)
Log Message
Merge r227194 - WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
https://bugs.webkit.org/show_bug.cgi?id=181844
Reviewed by Carlos Alberto Lopez Perez.
We always try to create the directory where to store the json file, but when the filename is given directly,
like in the bots, the current dir is used.
* Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
(WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
empty string.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/Tools/ChangeLog (227503 => 227504)
--- releases/WebKitGTK/webkit-2.18/Tools/ChangeLog 2018-01-24 10:02:16 UTC (rev 227503)
+++ releases/WebKitGTK/webkit-2.18/Tools/ChangeLog 2018-01-24 10:02:19 UTC (rev 227504)
@@ -1,5 +1,19 @@
2018-01-19 Carlos Garcia Campos <[email protected]>
+ WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
+ https://bugs.webkit.org/show_bug.cgi?id=181844
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ We always try to create the directory where to store the json file, but when the filename is given directly,
+ like in the bots, the current dir is used.
+
+ * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
+ (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
+ empty string.
+
+2018-01-19 Carlos Garcia Campos <[email protected]>
+
[GTK] WebDriver tests are running outside the jhbuild env
https://bugs.webkit.org/show_bug.cgi?id=181842
Modified: releases/WebKitGTK/webkit-2.18/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py (227503 => 227504)
--- releases/WebKitGTK/webkit-2.18/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py 2018-01-24 10:02:16 UTC (rev 227503)
+++ releases/WebKitGTK/webkit-2.18/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py 2018-01-24 10:02:19 UTC (rev 227504)
@@ -153,7 +153,7 @@
json_results['results'].append(results)
directory = os.path.dirname(output_path)
- if not os.path.exists(directory):
+ if directory and not os.path.exists(directory):
os.makedirs(directory)
with open(output_path, 'wb') as fp:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
