Title: [227520] trunk/Source/WebKit
Revision
227520
Author
commit-qu...@webkit.org
Date
2018-01-24 07:36:04 -0800 (Wed, 24 Jan 2018)

Log Message

Add Cache Storage engine assertion following on bug 181887
https://bugs.webkit.org/show_bug.cgi?id=181925

Patch by Youenn Fablet <you...@apple.com> on 2018-01-24
Reviewed by Alex Christensen.

In a normal environment, the folderPath should be the same as the path computed from the ClientOrigin.
Add assertion to verify this.

* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::clearCachesForOrigin):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (227519 => 227520)


--- trunk/Source/WebKit/ChangeLog	2018-01-24 15:25:14 UTC (rev 227519)
+++ trunk/Source/WebKit/ChangeLog	2018-01-24 15:36:04 UTC (rev 227520)
@@ -1,3 +1,16 @@
+2018-01-24  Youenn Fablet  <you...@apple.com>
+
+        Add Cache Storage engine assertion following on bug 181887
+        https://bugs.webkit.org/show_bug.cgi?id=181925
+
+        Reviewed by Alex Christensen.
+
+        In a normal environment, the folderPath should be the same as the path computed from the ClientOrigin.
+        Add assertion to verify this.
+
+        * NetworkProcess/cache/CacheStorageEngine.cpp:
+        (WebKit::CacheStorage::Engine::clearCachesForOrigin):
+
 2018-01-24  Michael Catanzaro  <mcatanz...@igalia.com>
 
         [GTK] Use GDK_EVENT_PROPAGATE and GDK_EVENT_STOP in WebKitWebViewBase.cpp

Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (227519 => 227520)


--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp	2018-01-24 15:25:14 UTC (rev 227519)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp	2018-01-24 15:36:04 UTC (rev 227520)
@@ -420,6 +420,7 @@
             if (folderOrigin->topOrigin != origin && folderOrigin->clientOrigin != origin)
                 return;
 
+            ASSERT(folderPath == cachesRootPath(*folderOrigin));
             m_ioQueue->dispatch([path = folderPath.isolatedCopy(), taskHandler = WTFMove(taskHandler)] {
                 deleteDirectoryRecursively(path);
             });
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to