Title: [227547] trunk/Tools
- Revision
- 227547
- Author
- [email protected]
- Date
- 2018-01-24 12:48:32 -0800 (Wed, 24 Jan 2018)
Log Message
REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
https://bugs.webkit.org/show_bug.cgi?id=181400
<rdar://problem/36358768>
Reviewed by Joseph Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
Always disable poisoning when running with --leaks, as this should work locally,
not just on bots.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (227546 => 227547)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2018-01-24 20:48:19 UTC (rev 227546)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2018-01-24 20:48:32 UTC (rev 227547)
@@ -129,7 +129,7 @@
},
{ "name": "Apple High Sierra (Leaks)", "type": "TestWebKit1Leaks", "builddir": "highsierra-leaks",
"platform": "mac-highsierra", "configuration": "release", "architectures": ["x86_64"],
- "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout", "--JSC_usePoisoning=0"],
+ "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout"],
"slavenames": ["bot121"]
},
{ "name": "Apple Sierra Debug (Build)", "type": "Build", "builddir": "sierra-debug",
Modified: trunk/Tools/ChangeLog (227546 => 227547)
--- trunk/Tools/ChangeLog 2018-01-24 20:48:19 UTC (rev 227546)
+++ trunk/Tools/ChangeLog 2018-01-24 20:48:32 UTC (rev 227547)
@@ -1,3 +1,17 @@
+2018-01-24 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
+ https://bugs.webkit.org/show_bug.cgi?id=181400
+ <rdar://problem/36358768>
+
+ Reviewed by Joseph Pecoraro.
+
+ * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
+ Always disable poisoning when running with --leaks, as this should work locally,
+ not just on bots.
+
2018-01-24 Daniel Bates <[email protected]>
REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (227546 => 227547)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2018-01-24 20:48:19 UTC (rev 227546)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2018-01-24 20:48:32 UTC (rev 227547)
@@ -429,6 +429,9 @@
if options.platform in ["gtk", "wpe"]:
options.webkit_test_runner = True
+ if options.leaks:
+ options.additional_env_var.append("JSC_usePoisoning=0")
+ options.additional_env_var.append("__XPC_JSC_usePoisoning=0")
def run(port, options, args, logging_stream):
logger = logging.getLogger()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
