Title: [227602] trunk
- Revision
- 227602
- Author
- [email protected]
- Date
- 2018-01-25 05:51:11 -0800 (Thu, 25 Jan 2018)
Log Message
WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName fails
https://bugs.webkit.org/show_bug.cgi?id=181984
Reviewed by Carlos Alberto Lopez Perez.
Source/WebDriver:
Platform name is expected to be lower case, so do not compre ignoring case.
Fixes: imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName
* WebDriverService.cpp:
(WebDriver::WebDriverService::matchCapabilities const):
WebDriverTests:
Remove expectations for imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName.
* TestExpectations.json:
Modified Paths
Diff
Modified: trunk/Source/WebDriver/ChangeLog (227601 => 227602)
--- trunk/Source/WebDriver/ChangeLog 2018-01-25 13:50:07 UTC (rev 227601)
+++ trunk/Source/WebDriver/ChangeLog 2018-01-25 13:51:11 UTC (rev 227602)
@@ -1,3 +1,17 @@
+2018-01-25 Carlos Garcia Campos <[email protected]>
+
+ WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName fails
+ https://bugs.webkit.org/show_bug.cgi?id=181984
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Platform name is expected to be lower case, so do not compre ignoring case.
+
+ Fixes: imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName
+
+ * WebDriverService.cpp:
+ (WebDriver::WebDriverService::matchCapabilities const):
+
2018-01-23 Carlos Garcia Campos <[email protected]>
WebDriver: several tests in imported/w3c/webdriver/tests/sessions/new_session/merge.py are failing
Modified: trunk/Source/WebDriver/WebDriverService.cpp (227601 => 227602)
--- trunk/Source/WebDriver/WebDriverService.cpp 2018-01-25 13:50:07 UTC (rev 227601)
+++ trunk/Source/WebDriver/WebDriverService.cpp 2018-01-25 13:51:11 UTC (rev 227602)
@@ -487,7 +487,7 @@
} else if (it->key == "platformName" && platformCapabilities.platformName) {
String platformName;
it->value->asString(platformName);
- if (!equalLettersIgnoringASCIICase(platformName, "any") && !equalIgnoringASCIICase(platformCapabilities.platformName.value(), platformName)) {
+ if (!equalLettersIgnoringASCIICase(platformName, "any") && platformCapabilities.platformName.value() != platformName) {
errorString = makeString("expected platformName ", platformCapabilities.platformName.value(), " but got ", platformName);
return nullptr;
}
Modified: trunk/WebDriverTests/ChangeLog (227601 => 227602)
--- trunk/WebDriverTests/ChangeLog 2018-01-25 13:50:07 UTC (rev 227601)
+++ trunk/WebDriverTests/ChangeLog 2018-01-25 13:51:11 UTC (rev 227602)
@@ -1,3 +1,14 @@
+2018-01-25 Carlos Garcia Campos <[email protected]>
+
+ WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName fails
+ https://bugs.webkit.org/show_bug.cgi?id=181984
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Remove expectations for imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName.
+
+ * TestExpectations.json:
+
2018-01-23 Carlos Garcia Campos <[email protected]>
WebDriver: several tests in imported/w3c/webdriver/tests/sessions/new_session/merge.py are failing
Modified: trunk/WebDriverTests/TestExpectations.json (227601 => 227602)
--- trunk/WebDriverTests/TestExpectations.json 2018-01-25 13:50:07 UTC (rev 227601)
+++ trunk/WebDriverTests/TestExpectations.json 2018-01-25 13:51:11 UTC (rev 227602)
@@ -193,9 +193,6 @@
},
"imported/w3c/webdriver/tests/sessions/new_session/merge.py": {
"subtests": {
- "test_merge_platformName": {
- "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181984"}}
- },
"test_merge_browserName": {
"expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181985"}}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
