Title: [227650] trunk/Source/WebCore
- Revision
- 227650
- Author
- [email protected]
- Date
- 2018-01-25 19:31:36 -0800 (Thu, 25 Jan 2018)
Log Message
Web Inspector: Remove unnecessary developerExtrasEnabled checks
https://bugs.webkit.org/show_bug.cgi?id=182156
Patch by Joseph Pecoraro <[email protected]> on 2018-01-25
Reviewed by Matt Baker.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::frameDocumentUpdatedImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
These checks should not be needed. The step above bails if there is
no inspector frontend, and there can be no inspector frontend unless
developer extras enabled are enabled.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227649 => 227650)
--- trunk/Source/WebCore/ChangeLog 2018-01-26 02:42:14 UTC (rev 227649)
+++ trunk/Source/WebCore/ChangeLog 2018-01-26 03:31:36 UTC (rev 227650)
@@ -1,3 +1,18 @@
+2018-01-25 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unnecessary developerExtrasEnabled checks
+ https://bugs.webkit.org/show_bug.cgi?id=182156
+
+ Reviewed by Matt Baker.
+
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
+ (WebCore::InspectorInstrumentation::frameDocumentUpdatedImpl):
+ (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
+ These checks should not be needed. The step above bails if there is
+ no inspector frontend, and there can be no inspector frontend unless
+ developer extras enabled are enabled.
+
2018-01-25 Wenson Hsieh <[email protected]>
Add localizable strings for extra-zoomed form controls
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (227649 => 227650)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2018-01-26 02:42:14 UTC (rev 227649)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2018-01-26 03:31:36 UTC (rev 227650)
@@ -573,9 +573,6 @@
void InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl(InstrumentingAgents& instrumentingAgents, DocumentLoader* loader, CachedResource* cachedResource)
{
- if (!instrumentingAgents.inspectorEnvironment().developerExtrasEnabled())
- return;
-
if (!loader || !cachedResource)
return;
@@ -733,8 +730,6 @@
void InspectorInstrumentation::frameDocumentUpdatedImpl(InstrumentingAgents& instrumentingAgents, Frame& frame)
{
- if (!instrumentingAgents.inspectorEnvironment().developerExtrasEnabled())
- return;
if (InspectorDOMAgent* domAgent = instrumentingAgents.inspectorDOMAgent())
domAgent->frameDocumentUpdated(frame);
}
@@ -915,9 +910,6 @@
void InspectorInstrumentation::didCreateWebSocketImpl(InstrumentingAgents& instrumentingAgents, unsigned long identifier, const URL& requestURL)
{
- if (!instrumentingAgents.inspectorEnvironment().developerExtrasEnabled())
- return;
-
if (InspectorNetworkAgent* networkAgent = instrumentingAgents.inspectorNetworkAgent())
networkAgent->didCreateWebSocket(identifier, requestURL);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
