Title: [227667] trunk/Source/WebInspectorUI
- Revision
- 227667
- Author
- [email protected]
- Date
- 2018-01-25 21:30:29 -0800 (Thu, 25 Jan 2018)
Log Message
Web Inspector: Network Table: Sort indicator is not displayed when sorted column is hidden and re-shown
https://bugs.webkit.org/show_bug.cgi?id=182164
<rdar://problem/36892619>
Patch by Joseph Pecoraro <[email protected]> on 2018-01-25
Reviewed by Brian Burg.
* UserInterface/Views/Table.js:
(WI.Table.prototype.showColumn):
Re-add the sort classes if the column being shown is the active sort column.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (227666 => 227667)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-01-26 05:22:24 UTC (rev 227666)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-01-26 05:30:29 UTC (rev 227667)
@@ -1,5 +1,17 @@
2018-01-25 Joseph Pecoraro <[email protected]>
+ Web Inspector: Network Table: Sort indicator is not displayed when sorted column is hidden and re-shown
+ https://bugs.webkit.org/show_bug.cgi?id=182164
+ <rdar://problem/36892619>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype.showColumn):
+ Re-add the sort classes if the column being shown is the active sort column.
+
+2018-01-25 Joseph Pecoraro <[email protected]>
+
Web Inspector: Network - Cookies view should behave better at narrow widths, all data is hidden
https://bugs.webkit.org/show_bug.cgi?id=182163
<rdar://problem/36893241>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (227666 => 227667)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-01-26 05:22:24 UTC (rev 227666)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-01-26 05:30:29 UTC (rev 227667)
@@ -394,6 +394,12 @@
if (column.headerView)
this.addSubview(column.headerView);
+ if (this._sortColumnIdentifier === column.identifier) {
+ let headerCell = this._headerElement.children[newColumnIndex];
+ headerCell.classList.toggle("sort-ascending", this._sortOrder === WI.Table.SortOrder.Ascending);
+ headerCell.classList.toggle("sort-descending", this._sortOrder === WI.Table.SortOrder.Descending);
+ }
+
// We haven't yet done any layout, nothing to do.
if (!this._columnWidths)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
