Title: [227685] trunk/Source/_javascript_Core
- Revision
- 227685
- Author
- [email protected]
- Date
- 2018-01-26 11:32:05 -0800 (Fri, 26 Jan 2018)
Log Message
_javascript_Core builtins should be partially minified in Release builds not Debug builds
https://bugs.webkit.org/show_bug.cgi?id=182165
Patch by Joseph Pecoraro <[email protected]> on 2018-01-26
Reviewed by Keith Miller.
* Scripts/builtins/builtins_model.py:
(BuiltinFunction.fromString):
Apply minifications on Release builds instead of Debug builds.
Also eliminate leading whitespace.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (227684 => 227685)
--- trunk/Source/_javascript_Core/ChangeLog 2018-01-26 18:52:25 UTC (rev 227684)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-01-26 19:32:05 UTC (rev 227685)
@@ -1,3 +1,15 @@
+2018-01-26 Joseph Pecoraro <[email protected]>
+
+ _javascript_Core builtins should be partially minified in Release builds not Debug builds
+ https://bugs.webkit.org/show_bug.cgi?id=182165
+
+ Reviewed by Keith Miller.
+
+ * Scripts/builtins/builtins_model.py:
+ (BuiltinFunction.fromString):
+ Apply minifications on Release builds instead of Debug builds.
+ Also eliminate leading whitespace.
+
2018-01-26 Filip Pizlo <[email protected]>
Disable TLS-based TLCs
Modified: trunk/Source/_javascript_Core/Scripts/builtins/builtins_model.py (227684 => 227685)
--- trunk/Source/_javascript_Core/Scripts/builtins/builtins_model.py 2018-01-26 18:52:25 UTC (rev 227684)
+++ trunk/Source/_javascript_Core/Scripts/builtins/builtins_model.py 2018-01-26 19:32:05 UTC (rev 227685)
@@ -57,6 +57,7 @@
flagAnnotationCommentRegExp = re.compile(r"^\/\/ @(\w+)[^=]*?\n", re.MULTILINE | re.DOTALL)
lineWithOnlySingleLineCommentRegExp = re.compile(r"^\s*\/\/\n", re.MULTILINE | re.DOTALL)
lineWithTrailingSingleLineCommentRegExp = re.compile(r"\s*\/\/\n", re.MULTILINE | re.DOTALL)
+leadingWhitespaceRegExp = re.compile(r"^ +", re.MULTILINE | re.DOTALL)
multipleEmptyLinesRegExp = re.compile(r"\n{2,}", re.MULTILINE | re.DOTALL)
class ParseException(Exception):
@@ -125,9 +126,10 @@
overridden_name = overriddenNameMatch.group(1)
function_source = functionOverriddenNameRegExp.sub("", function_source)
- if os.getenv("CONFIGURATION", "Debug").startswith("Debug"):
+ if not os.getenv("CONFIGURATION", "Debug").startswith("Debug"):
function_source = lineWithOnlySingleLineCommentRegExp.sub("", function_source)
function_source = lineWithTrailingSingleLineCommentRegExp.sub("\n", function_source)
+ function_source = leadingWhitespaceRegExp.sub("", function_source)
function_source = multipleEmptyLinesRegExp.sub("\n", function_source)
function_name = functionNameRegExp.findall(function_source)[0]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
