Title: [227693] trunk/Source/_javascript_Core
Revision
227693
Author
joep...@webkit.org
Date
2018-01-26 13:23:31 -0800 (Fri, 26 Jan 2018)

Log Message

Rebaselining builtin generator tests after r227685.

Unreviewed.

* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result:
* Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result:
* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
It used to be that the builtins generator was minifying by default. That was an accident
and we now only minify on Release builds. The generator tests are now getting the
default unminified output behavior so they need to update their expectations
for some extra whitespace.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227692 => 227693)


--- trunk/Source/_javascript_Core/ChangeLog	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-26 21:23:31 UTC (rev 227693)
@@ -1,3 +1,27 @@
+2018-01-26  Joseph Pecoraro  <pecor...@apple.com>
+
+        Rebaselining builtin generator tests after r227685.
+
+        Unreviewed.
+
+        * Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result:
+        * Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result:
+        * Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result:
+        * Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result:
+        * Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result:
+        * Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result:
+        * Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result:
+        * Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
+        * Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
+        * Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
+        * Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
+        * Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
+        * Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
+        It used to be that the builtins generator was minifying by default. That was an accident
+        and we now only minify on Release builds. The generator tests are now getting the
+        default unminified output behavior so they need to update their expectations
+        for some extra whitespace.
+
 2018-01-26  Mark Lam  <mark....@apple.com>
 
         We should only append ParserArenaDeletable pointers to ParserArena::m_deletableObjects.

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -116,35 +116,41 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_builtinPromiseRejectPromiseCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPromiseRejectPromiseCodeLength = 410;
+const int s_builtinPromiseRejectPromiseCodeLength = 413;
 static const JSC::Intrinsic s_builtinPromiseRejectPromiseCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPromiseRejectPromiseCode =
     "(function (promise, reason)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var reactions = promise.@promiseRejectReactions;\n" \
     "    promise.@promiseResult = reason;\n" \
     "    promise.@promiseFulfillReactions = undefined;\n" \
     "    promise.@promiseRejectReactions = undefined;\n" \
     "    promise.@promiseState = @promiseRejected;\n" \
+    "\n" \
     "    @InspectorInstrumentation.promiseRejected(promise, reason, reactions);\n" \
+    "\n" \
     "    @triggerPromiseReactions(reactions, reason);\n" \
     "})\n" \
 ;
 
 const JSC::ConstructAbility s_builtinPromiseFulfillPromiseCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPromiseFulfillPromiseCodeLength = 409;
+const int s_builtinPromiseFulfillPromiseCodeLength = 412;
 static const JSC::Intrinsic s_builtinPromiseFulfillPromiseCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPromiseFulfillPromiseCode =
     "(function (promise, value)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var reactions = promise.@promiseFulfillReactions;\n" \
     "    promise.@promiseResult = value;\n" \
     "    promise.@promiseFulfillReactions = undefined;\n" \
     "    promise.@promiseRejectReactions = undefined;\n" \
     "    promise.@promiseState = @promiseFulfilled;\n" \
+    "\n" \
     "    @InspectorInstrumentation.promiseFulfilled(promise, value, reactions);\n" \
+    "\n" \
     "    @triggerPromiseReactions(reactions, value);\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -115,35 +115,41 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_builtinPromiseRejectPromiseCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPromiseRejectPromiseCodeLength = 410;
+const int s_builtinPromiseRejectPromiseCodeLength = 413;
 static const JSC::Intrinsic s_builtinPromiseRejectPromiseCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPromiseRejectPromiseCode =
     "(function (promise, reason)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var reactions = promise.@promiseRejectReactions;\n" \
     "    promise.@promiseResult = reason;\n" \
     "    promise.@promiseFulfillReactions = undefined;\n" \
     "    promise.@promiseRejectReactions = undefined;\n" \
     "    promise.@promiseState = @promiseRejected;\n" \
+    "\n" \
     "    @InspectorInstrumentation.promiseRejected(promise, reason, reactions);\n" \
+    "\n" \
     "    @triggerPromiseReactions(reactions, reason);\n" \
     "})\n" \
 ;
 
 const JSC::ConstructAbility s_builtinPromiseFulfillPromiseCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPromiseFulfillPromiseCodeLength = 409;
+const int s_builtinPromiseFulfillPromiseCodeLength = 412;
 static const JSC::Intrinsic s_builtinPromiseFulfillPromiseCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPromiseFulfillPromiseCode =
     "(function (promise, value)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var reactions = promise.@promiseFulfillReactions;\n" \
     "    promise.@promiseResult = value;\n" \
     "    promise.@promiseFulfillReactions = undefined;\n" \
     "    promise.@promiseRejectReactions = undefined;\n" \
     "    promise.@promiseState = @promiseFulfilled;\n" \
+    "\n" \
     "    @InspectorInstrumentation.promiseFulfilled(promise, value, reactions);\n" \
+    "\n" \
     "    @triggerPromiseReactions(reactions, value);\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -128,12 +128,13 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_builtinPrototypeEveryCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeEveryCodeLength = 760;
+const int s_builtinPrototypeEveryCodeLength = 762;
 static const JSC::Intrinsic s_builtinPrototypeEveryCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPrototypeEveryCode =
     "(function (callback )\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (this === null)\n" \
     "        throw new @TypeError(\"Array.prototype.every requires that |this| not be null\");\n" \
     "    \n" \
@@ -142,6 +143,7 @@
     "    \n" \
     "    var array = @Object(this);\n" \
     "    var length = @toLength(array.length);\n" \
+    "\n" \
     "    if (typeof callback !== \"function\")\n" \
     "        throw new @TypeError(\"Array.prototype.every callback must be a function\");\n" \
     "    \n" \
@@ -159,12 +161,13 @@
 ;
 
 const JSC::ConstructAbility s_builtinPrototypeForEachCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeForEachCodeLength = 692;
+const int s_builtinPrototypeForEachCodeLength = 694;
 static const JSC::Intrinsic s_builtinPrototypeForEachCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPrototypeForEachCode =
     "(function (callback )\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (this === null)\n" \
     "        throw new @TypeError(\"Array.prototype.forEach requires that |this| not be null\");\n" \
     "    \n" \
@@ -173,6 +176,7 @@
     "    \n" \
     "    var array = @Object(this);\n" \
     "    var length = @toLength(array.length);\n" \
+    "\n" \
     "    if (typeof callback !== \"function\")\n" \
     "        throw new @TypeError(\"Array.prototype.forEach callback must be a function\");\n" \
     "    \n" \
@@ -186,18 +190,24 @@
 ;
 
 const JSC::ConstructAbility s_builtinPrototypeMatchCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeMatchCodeLength = 1198;
+const int s_builtinPrototypeMatchCodeLength = 1238;
 static const JSC::Intrinsic s_builtinPrototypeMatchCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPrototypeMatchCode =
     "(function (strArg)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (!@isObject(this))\n" \
     "        @throwTypeError(\"RegExp.prototype.@@match requires that |this| be an Object\");\n" \
+    "\n" \
     "    let regexp = this;\n" \
+    "\n" \
+    "    //\n" \
     "    if (!@hasObservableSideEffectsForRegExpMatch(regexp))\n" \
     "        return @regExpMatchFast.@call(regexp, strArg);\n" \
+    "\n" \
     "    let str = @toString(strArg);\n" \
+    "\n" \
     "    if (!regexp.global)\n" \
     "        return @regExpExec(regexp, str);\n" \
     "    \n" \
@@ -204,7 +214,12 @@
     "    let unicode = regexp.unicode;\n" \
     "    regexp.lastIndex = 0;\n" \
     "    let resultList = [];\n" \
+    "\n" \
+    "    //\n" \
+    "    //\n" \
+    "    //\n" \
     "    const maximumReasonableMatchSize = 100000000;\n" \
+    "\n" \
     "    while (true) {\n" \
     "        let result = @regExpExec(regexp, str);\n" \
     "        \n" \
@@ -213,13 +228,18 @@
     "                return null;\n" \
     "            return resultList;\n" \
     "        }\n" \
+    "\n" \
     "        if (resultList.length > maximumReasonableMatchSize)\n" \
     "            @throwOutOfMemoryError();\n" \
+    "\n" \
     "        if (!@isObject(result))\n" \
     "            @throwTypeError(\"RegExp.prototype.@@match call to RegExp.exec didn't return null or an object\");\n" \
+    "\n" \
     "        let resultString = @toString(result[0]);\n" \
+    "\n" \
     "        if (!resultString.length)\n" \
     "            regexp.lastIndex = @advanceStringIndex(str, regexp.lastIndex, unicode);\n" \
+    "\n" \
     "        resultList.@push(resultString);\n" \
     "    }\n" \
     "})\n" \
@@ -226,19 +246,31 @@
 ;
 
 const JSC::ConstructAbility s_builtinPrototypeTestCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeTestCodeLength = 456;
+const int s_builtinPrototypeTestCodeLength = 504;
 static const JSC::Intrinsic s_builtinPrototypeTestCodeIntrinsic = JSC::RegExpTestIntrinsic;
 const char* s_builtinPrototypeTestCode =
     "(function (strArg)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    let regexp = this;\n" \
+    "\n" \
+    "    //\n" \
     "    if (@isRegExpObject(regexp) && @tryGetById(regexp, \"exec\") === @regExpBuiltinExec)\n" \
     "        return @regExpTestFast.@call(regexp, strArg);\n" \
+    "\n" \
+    "    //\n" \
+    "    //\n" \
     "    if (!@isObject(regexp))\n" \
     "        @throwTypeError(\"RegExp.prototype.test requires that |this| be an Object\");\n" \
+    "\n" \
+    "    //\n" \
     "    let str = @toString(strArg);\n" \
+    "\n" \
+    "    //\n" \
     "    let match = @regExpExec(regexp, str);\n" \
+    "\n" \
+    "    //\n" \
     "    if (match !== null)\n" \
     "        return true;\n" \
     "    return false;\n" \

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -129,12 +129,13 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_builtinPrototypeEveryCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeEveryCodeLength = 760;
+const int s_builtinPrototypeEveryCodeLength = 762;
 static const JSC::Intrinsic s_builtinPrototypeEveryCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPrototypeEveryCode =
     "(function (callback )\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (this === null)\n" \
     "        throw new @TypeError(\"Array.prototype.every requires that |this| not be null\");\n" \
     "    \n" \
@@ -143,6 +144,7 @@
     "    \n" \
     "    var array = @Object(this);\n" \
     "    var length = @toLength(array.length);\n" \
+    "\n" \
     "    if (typeof callback !== \"function\")\n" \
     "        throw new @TypeError(\"Array.prototype.every callback must be a function\");\n" \
     "    \n" \
@@ -160,12 +162,13 @@
 ;
 
 const JSC::ConstructAbility s_builtinPrototypeForEachCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeForEachCodeLength = 692;
+const int s_builtinPrototypeForEachCodeLength = 694;
 static const JSC::Intrinsic s_builtinPrototypeForEachCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPrototypeForEachCode =
     "(function (callback )\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (this === null)\n" \
     "        throw new @TypeError(\"Array.prototype.forEach requires that |this| not be null\");\n" \
     "    \n" \
@@ -174,6 +177,7 @@
     "    \n" \
     "    var array = @Object(this);\n" \
     "    var length = @toLength(array.length);\n" \
+    "\n" \
     "    if (typeof callback !== \"function\")\n" \
     "        throw new @TypeError(\"Array.prototype.forEach callback must be a function\");\n" \
     "    \n" \
@@ -187,18 +191,24 @@
 ;
 
 const JSC::ConstructAbility s_builtinPrototypeMatchCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeMatchCodeLength = 1198;
+const int s_builtinPrototypeMatchCodeLength = 1238;
 static const JSC::Intrinsic s_builtinPrototypeMatchCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinPrototypeMatchCode =
     "(function (strArg)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (!@isObject(this))\n" \
     "        @throwTypeError(\"RegExp.prototype.@@match requires that |this| be an Object\");\n" \
+    "\n" \
     "    let regexp = this;\n" \
+    "\n" \
+    "    //\n" \
     "    if (!@hasObservableSideEffectsForRegExpMatch(regexp))\n" \
     "        return @regExpMatchFast.@call(regexp, strArg);\n" \
+    "\n" \
     "    let str = @toString(strArg);\n" \
+    "\n" \
     "    if (!regexp.global)\n" \
     "        return @regExpExec(regexp, str);\n" \
     "    \n" \
@@ -205,7 +215,12 @@
     "    let unicode = regexp.unicode;\n" \
     "    regexp.lastIndex = 0;\n" \
     "    let resultList = [];\n" \
+    "\n" \
+    "    //\n" \
+    "    //\n" \
+    "    //\n" \
     "    const maximumReasonableMatchSize = 100000000;\n" \
+    "\n" \
     "    while (true) {\n" \
     "        let result = @regExpExec(regexp, str);\n" \
     "        \n" \
@@ -214,13 +229,18 @@
     "                return null;\n" \
     "            return resultList;\n" \
     "        }\n" \
+    "\n" \
     "        if (resultList.length > maximumReasonableMatchSize)\n" \
     "            @throwOutOfMemoryError();\n" \
+    "\n" \
     "        if (!@isObject(result))\n" \
     "            @throwTypeError(\"RegExp.prototype.@@match call to RegExp.exec didn't return null or an object\");\n" \
+    "\n" \
     "        let resultString = @toString(result[0]);\n" \
+    "\n" \
     "        if (!resultString.length)\n" \
     "            regexp.lastIndex = @advanceStringIndex(str, regexp.lastIndex, unicode);\n" \
+    "\n" \
     "        resultList.@push(resultString);\n" \
     "    }\n" \
     "})\n" \
@@ -227,19 +247,31 @@
 ;
 
 const JSC::ConstructAbility s_builtinPrototypeTestCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinPrototypeTestCodeLength = 456;
+const int s_builtinPrototypeTestCodeLength = 504;
 static const JSC::Intrinsic s_builtinPrototypeTestCodeIntrinsic = JSC::RegExpTestIntrinsic;
 const char* s_builtinPrototypeTestCode =
     "(function (strArg)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    let regexp = this;\n" \
+    "\n" \
+    "    //\n" \
     "    if (@isRegExpObject(regexp) && @tryGetById(regexp, \"exec\") === @regExpBuiltinExec)\n" \
     "        return @regExpTestFast.@call(regexp, strArg);\n" \
+    "\n" \
+    "    //\n" \
+    "    //\n" \
     "    if (!@isObject(regexp))\n" \
     "        @throwTypeError(\"RegExp.prototype.test requires that |this| be an Object\");\n" \
+    "\n" \
+    "    //\n" \
     "    let str = @toString(strArg);\n" \
+    "\n" \
+    "    //\n" \
     "    let match = @regExpExec(regexp, str);\n" \
+    "\n" \
+    "    //\n" \
     "    if (match !== null)\n" \
     "        return true;\n" \
     "    return false;\n" \

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -114,13 +114,15 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_builtinConstructorOfCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinConstructorOfCodeLength = 286;
+const int s_builtinConstructorOfCodeLength = 294;
 static const JSC::Intrinsic s_builtinConstructorOfCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinConstructorOfCode =
     "(function ()\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var length = arguments.length;\n" \
+    "    //\n" \
     "    var array = typeof this === 'function' ? new this(length) : new @Array(length);\n" \
     "    for (var k = 0; k < length; ++k)\n" \
     "        @putByValDirect(array, k, arguments[k]);\n" \
@@ -130,35 +132,50 @@
 ;
 
 const JSC::ConstructAbility s_builtinConstructorFromCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinConstructorFromCodeLength = 1979;
+const int s_builtinConstructorFromCodeLength = 2046;
 static const JSC::Intrinsic s_builtinConstructorFromCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinConstructorFromCode =
     "(function (items )\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var thisObj = this;\n" \
+    "\n" \
     "    var mapFn = arguments.length > 1 ? arguments[1] : undefined;\n" \
+    "\n" \
     "    var thisArg;\n" \
+    "\n" \
     "    if (mapFn !== undefined) {\n" \
     "        if (typeof mapFn !== \"function\")\n" \
     "            throw new @TypeError(\"Array.from requires that the second argument, when provided, be a function\");\n" \
+    "\n" \
     "        if (arguments.length > 2)\n" \
     "            thisArg = arguments[2];\n" \
     "    }\n" \
+    "\n" \
     "    if (items == null)\n" \
     "        throw new @TypeError(\"Array.from requires an array-like object - not null or undefined\");\n" \
+    "\n" \
     "    var iteratorMethod = items[@symbolIterator];\n" \
     "    if (iteratorMethod != null) {\n" \
     "        if (typeof iteratorMethod !== \"function\")\n" \
     "            throw new @TypeError(\"Array.from requires that the property of the first argument, items[Symbol.iterator], when exists, be a function\");\n" \
+    "\n" \
+    "        //\n" \
     "        var result = (typeof thisObj === \"function\") ? @Object(new thisObj()) : [];\n" \
+    "\n" \
     "        var k = 0;\n" \
     "        var iterator = iteratorMethod.@call(items);\n" \
+    "\n" \
+    "        //\n" \
+    "        //\n" \
+    "        //\n" \
     "        var wrapper = {\n" \
     "            [@symbolIterator]() {\n" \
     "                return iterator;\n" \
     "            }\n" \
     "        };\n" \
+    "\n" \
     "        for (var value of wrapper) {\n" \
     "            if (mapFn)\n" \
     "                @putByValDirect(result, k, thisArg === undefined ? mapFn(value, k) : mapFn.@call(thisArg, value, k));\n" \
@@ -166,12 +183,17 @@
     "                @putByValDirect(result, k, value);\n" \
     "            k += 1;\n" \
     "        }\n" \
+    "\n" \
     "        result.length = k;\n" \
     "        return result;\n" \
     "    }\n" \
+    "\n" \
     "    var arrayLike = @Object(items);\n" \
     "    var arrayLikeLength = @toLength(arrayLike.length);\n" \
+    "\n" \
+    "    //\n" \
     "    var result = (typeof thisObj === \"function\") ? @Object(new thisObj(arrayLikeLength)) : new @Array(arrayLikeLength);\n" \
+    "\n" \
     "    var k = 0;\n" \
     "    while (k < arrayLikeLength) {\n" \
     "        var value = arrayLike[k];\n" \
@@ -181,6 +203,7 @@
     "            @putByValDirect(result, k, value);\n" \
     "        k += 1;\n" \
     "    }\n" \
+    "\n" \
     "    result.length = arrayLikeLength;\n" \
     "    return result;\n" \
     "})\n" \

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -113,13 +113,15 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_builtinConstructorOfCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinConstructorOfCodeLength = 286;
+const int s_builtinConstructorOfCodeLength = 294;
 static const JSC::Intrinsic s_builtinConstructorOfCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinConstructorOfCode =
     "(function ()\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var length = arguments.length;\n" \
+    "    //\n" \
     "    var array = typeof this === 'function' ? new this(length) : new @Array(length);\n" \
     "    for (var k = 0; k < length; ++k)\n" \
     "        @putByValDirect(array, k, arguments[k]);\n" \
@@ -129,35 +131,50 @@
 ;
 
 const JSC::ConstructAbility s_builtinConstructorFromCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_builtinConstructorFromCodeLength = 1979;
+const int s_builtinConstructorFromCodeLength = 2046;
 static const JSC::Intrinsic s_builtinConstructorFromCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_builtinConstructorFromCode =
     "(function (items )\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    var thisObj = this;\n" \
+    "\n" \
     "    var mapFn = arguments.length > 1 ? arguments[1] : undefined;\n" \
+    "\n" \
     "    var thisArg;\n" \
+    "\n" \
     "    if (mapFn !== undefined) {\n" \
     "        if (typeof mapFn !== \"function\")\n" \
     "            throw new @TypeError(\"Array.from requires that the second argument, when provided, be a function\");\n" \
+    "\n" \
     "        if (arguments.length > 2)\n" \
     "            thisArg = arguments[2];\n" \
     "    }\n" \
+    "\n" \
     "    if (items == null)\n" \
     "        throw new @TypeError(\"Array.from requires an array-like object - not null or undefined\");\n" \
+    "\n" \
     "    var iteratorMethod = items[@symbolIterator];\n" \
     "    if (iteratorMethod != null) {\n" \
     "        if (typeof iteratorMethod !== \"function\")\n" \
     "            throw new @TypeError(\"Array.from requires that the property of the first argument, items[Symbol.iterator], when exists, be a function\");\n" \
+    "\n" \
+    "        //\n" \
     "        var result = (typeof thisObj === \"function\") ? @Object(new thisObj()) : [];\n" \
+    "\n" \
     "        var k = 0;\n" \
     "        var iterator = iteratorMethod.@call(items);\n" \
+    "\n" \
+    "        //\n" \
+    "        //\n" \
+    "        //\n" \
     "        var wrapper = {\n" \
     "            [@symbolIterator]() {\n" \
     "                return iterator;\n" \
     "            }\n" \
     "        };\n" \
+    "\n" \
     "        for (var value of wrapper) {\n" \
     "            if (mapFn)\n" \
     "                @putByValDirect(result, k, thisArg === undefined ? mapFn(value, k) : mapFn.@call(thisArg, value, k));\n" \
@@ -165,12 +182,17 @@
     "                @putByValDirect(result, k, value);\n" \
     "            k += 1;\n" \
     "        }\n" \
+    "\n" \
     "        result.length = k;\n" \
     "        return result;\n" \
     "    }\n" \
+    "\n" \
     "    var arrayLike = @Object(items);\n" \
     "    var arrayLikeLength = @toLength(arrayLike.length);\n" \
+    "\n" \
+    "    //\n" \
     "    var result = (typeof thisObj === \"function\") ? @Object(new thisObj(arrayLikeLength)) : new @Array(arrayLikeLength);\n" \
+    "\n" \
     "    var k = 0;\n" \
     "    while (k < arrayLikeLength) {\n" \
     "        var value = arrayLike[k];\n" \
@@ -180,6 +202,7 @@
     "            @putByValDirect(result, k, value);\n" \
     "        k += 1;\n" \
     "    }\n" \
+    "\n" \
     "    result.length = arrayLikeLength;\n" \
     "    return result;\n" \
     "})\n" \

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -115,23 +115,25 @@
 namespace JSC {
 
 const JSC::ConstructAbility s_internalClashingNamesIsReadableStreamLockedCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_internalClashingNamesIsReadableStreamLockedCodeLength = 70;
+const int s_internalClashingNamesIsReadableStreamLockedCodeLength = 71;
 static const JSC::Intrinsic s_internalClashingNamesIsReadableStreamLockedCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_internalClashingNamesIsReadableStreamLockedCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;
 
 const JSC::ConstructAbility s_internalClashingNamesIsReadableStreamLockedCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_internalClashingNamesIsReadableStreamLockedCodeLength = 70;
+const int s_internalClashingNamesIsReadableStreamLockedCodeLength = 71;
 static const JSC::Intrinsic s_internalClashingNamesIsReadableStreamLockedCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_internalClashingNamesIsReadableStreamLockedCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -204,12 +204,13 @@
 namespace WebCore {
 
 const JSC::ConstructAbility s_anotherGuardedInternalBuiltinLetsFetchCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_anotherGuardedInternalBuiltinLetsFetchCodeLength = 82;
+const int s_anotherGuardedInternalBuiltinLetsFetchCodeLength = 83;
 static const JSC::Intrinsic s_anotherGuardedInternalBuiltinLetsFetchCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_anotherGuardedInternalBuiltinLetsFetchCode =
     "(function ()\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return @fetchRequest(new @Request(\"yes\"));\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -174,12 +174,13 @@
 namespace WebCore {
 
 const JSC::ConstructAbility s_arbitraryConditionalGuardIsReadableStreamLockedCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_arbitraryConditionalGuardIsReadableStreamLockedCodeLength = 70;
+const int s_arbitraryConditionalGuardIsReadableStreamLockedCodeLength = 71;
 static const JSC::Intrinsic s_arbitraryConditionalGuardIsReadableStreamLockedCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_arbitraryConditionalGuardIsReadableStreamLockedCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -174,12 +174,13 @@
 namespace WebCore {
 
 const JSC::ConstructAbility s_guardedBuiltinIsReadableStreamLockedCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_guardedBuiltinIsReadableStreamLockedCodeLength = 70;
+const int s_guardedBuiltinIsReadableStreamLockedCodeLength = 71;
 static const JSC::Intrinsic s_guardedBuiltinIsReadableStreamLockedCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_guardedBuiltinIsReadableStreamLockedCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -206,12 +206,13 @@
 namespace WebCore {
 
 const JSC::ConstructAbility s_guardedInternalBuiltinIsReadableStreamLockedCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_guardedInternalBuiltinIsReadableStreamLockedCodeLength = 70;
+const int s_guardedInternalBuiltinIsReadableStreamLockedCodeLength = 71;
 static const JSC::Intrinsic s_guardedInternalBuiltinIsReadableStreamLockedCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_guardedInternalBuiltinIsReadableStreamLockedCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -168,12 +168,13 @@
 namespace WebCore {
 
 const JSC::ConstructAbility s_unguardedBuiltinIsReadableStreamLockedCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_unguardedBuiltinIsReadableStreamLockedCodeLength = 70;
+const int s_unguardedBuiltinIsReadableStreamLockedCodeLength = 71;
 static const JSC::Intrinsic s_unguardedBuiltinIsReadableStreamLockedCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_unguardedBuiltinIsReadableStreamLockedCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;

Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result (227692 => 227693)


--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result	2018-01-26 21:14:17 UTC (rev 227692)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result	2018-01-26 21:23:31 UTC (rev 227693)
@@ -220,23 +220,25 @@
 namespace WebCore {
 
 const JSC::ConstructAbility s_xmlCasingTestXMLCasingTestCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_xmlCasingTestXMLCasingTestCodeLength = 70;
+const int s_xmlCasingTestXMLCasingTestCodeLength = 71;
 static const JSC::Intrinsic s_xmlCasingTestXMLCasingTestCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_xmlCasingTestXMLCasingTestCode =
     "(function (stream)\n" \
     "{\n" \
     "   \"use strict\";\n" \
+    "\n" \
     "    return !!stream.@reader;\n" \
     "})\n" \
 ;
 
 const JSC::ConstructAbility s_xmlCasingTestCssCasingTestCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_xmlCasingTestCssCasingTestCodeLength = 401;
+const int s_xmlCasingTestCssCasingTestCodeLength = 402;
 static const JSC::Intrinsic s_xmlCasingTestCssCasingTestCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_xmlCasingTestCssCasingTestCode =
     "(function (stream, reason)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    if (stream.@state === @readableStreamClosed)\n" \
     "        return Promise.resolve();\n" \
     "    if (stream.@state === @readableStreamErrored)\n" \
@@ -248,12 +250,13 @@
 ;
 
 const JSC::ConstructAbility s_xmlCasingTestUrlCasingTestCodeConstructAbility = JSC::ConstructAbility::CannotConstruct;
-const int s_xmlCasingTestUrlCasingTestCodeLength = 337;
+const int s_xmlCasingTestUrlCasingTestCodeLength = 338;
 static const JSC::Intrinsic s_xmlCasingTestUrlCasingTestCodeIntrinsic = JSC::NoIntrinsic;
 const char* s_xmlCasingTestUrlCasingTestCode =
     "(function (object, key, args)\n" \
     "{\n" \
     "    \"use strict\";\n" \
+    "\n" \
     "    try {\n" \
     "        var method = object[key];\n" \
     "        if (typeof method === \"undefined\")\n" \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to