Title: [227702] trunk/Source/WebCore
- Revision
- 227702
- Author
- [email protected]
- Date
- 2018-01-26 16:45:43 -0800 (Fri, 26 Jan 2018)
Log Message
REGRESSION (r222961): Clear function not clearing whole screen when antialias is set to false
https://bugs.webkit.org/show_bug.cgi?id=179368
<rdar://problem/36111549>
Reviewed by Sam Weinig.
When we changed from using a CAOpenGLLayer to a regular CALayer, we should
have also swapped the "opaque" property to "contentsOpaque".
Covered by the existing test: fast/canvas/webgl/context-attributes-alpha.html
(when run on some hardware!)
* platform/graphics/cocoa/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227701 => 227702)
--- trunk/Source/WebCore/ChangeLog 2018-01-27 00:43:27 UTC (rev 227701)
+++ trunk/Source/WebCore/ChangeLog 2018-01-27 00:45:43 UTC (rev 227702)
@@ -1,3 +1,20 @@
+2018-01-26 Dean Jackson <[email protected]>
+
+ REGRESSION (r222961): Clear function not clearing whole screen when antialias is set to false
+ https://bugs.webkit.org/show_bug.cgi?id=179368
+ <rdar://problem/36111549>
+
+ Reviewed by Sam Weinig.
+
+ When we changed from using a CAOpenGLLayer to a regular CALayer, we should
+ have also swapped the "opaque" property to "contentsOpaque".
+
+ Covered by the existing test: fast/canvas/webgl/context-attributes-alpha.html
+ (when run on some hardware!)
+
+ * platform/graphics/cocoa/WebGLLayer.mm:
+ (-[WebGLLayer initWithGraphicsContext3D:]):
+
2018-01-26 Mark Lam <[email protected]>
Add infrastructure for pointer preparation.
Modified: trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm (227701 => 227702)
--- trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm 2018-01-27 00:43:27 UTC (rev 227701)
+++ trunk/Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm 2018-01-27 00:45:43 UTC (rev 227702)
@@ -54,8 +54,7 @@
self = [super init];
_devicePixelRatio = context->getContextAttributes().devicePixelRatio;
#if PLATFORM(MAC)
- if (!context->getContextAttributes().alpha)
- self.opaque = YES;
+ self.contentsOpaque = !context->getContextAttributes().alpha;
self.transform = CATransform3DIdentity;
self.contentsScale = _devicePixelRatio;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
