Title: [227727] trunk/Source/WebCore
Revision
227727
Author
[email protected]
Date
2018-01-29 02:56:57 -0800 (Mon, 29 Jan 2018)

Log Message

Construct GraphicsContext with NonPaintingReasons::NoReason in FrameView::adjustPageHeightDeprecated()
https://bugs.webkit.org/show_bug.cgi?id=182235

Reviewed by Carlos Garcia Campos.

Pass the NonPaintingReasons::NoReason value to the GraphicsContext
constructor in FrameView::adjustPageHeightDeprecated(). This has the
same effect as when passing a null PlatformGraphicsContext to the
constructor, which effectively disables any painting through that
GraphicsContext, but doesn't have a platform-specific connotation.

No new tests -- no change in functionality.

* page/FrameView.cpp:
(WebCore::FrameView::adjustPageHeightDeprecated):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (227726 => 227727)


--- trunk/Source/WebCore/ChangeLog	2018-01-29 10:56:09 UTC (rev 227726)
+++ trunk/Source/WebCore/ChangeLog	2018-01-29 10:56:57 UTC (rev 227727)
@@ -1,5 +1,23 @@
 2018-01-29  Zan Dobersek  <[email protected]>
 
+        Construct GraphicsContext with NonPaintingReasons::NoReason in FrameView::adjustPageHeightDeprecated()
+        https://bugs.webkit.org/show_bug.cgi?id=182235
+
+        Reviewed by Carlos Garcia Campos.
+
+        Pass the NonPaintingReasons::NoReason value to the GraphicsContext
+        constructor in FrameView::adjustPageHeightDeprecated(). This has the
+        same effect as when passing a null PlatformGraphicsContext to the
+        constructor, which effectively disables any painting through that
+        GraphicsContext, but doesn't have a platform-specific connotation.
+
+        No new tests -- no change in functionality.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::adjustPageHeightDeprecated):
+
+2018-01-29  Zan Dobersek  <[email protected]>
+
         [Cairo] Remove the GraphicsContext(cairo_t*) constructor
         https://bugs.webkit.org/show_bug.cgi?id=182234
 

Modified: trunk/Source/WebCore/page/FrameView.cpp (227726 => 227727)


--- trunk/Source/WebCore/page/FrameView.cpp	2018-01-29 10:56:09 UTC (rev 227726)
+++ trunk/Source/WebCore/page/FrameView.cpp	2018-01-29 10:56:57 UTC (rev 227727)
@@ -4409,7 +4409,7 @@
 
     }
     // Use a context with painting disabled.
-    GraphicsContext context((PlatformGraphicsContext*)nullptr);
+    GraphicsContext context(GraphicsContext::NonPaintingReasons::NoReasons);
     renderView->setTruncatedAt(static_cast<int>(floorf(oldBottom)));
     IntRect dirtyRect(0, static_cast<int>(floorf(oldTop)), renderView->layoutOverflowRect().maxX(), static_cast<int>(ceilf(oldBottom - oldTop)));
     renderView->setPrintRect(dirtyRect);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to