Title: [227733] trunk/Source/WebKit
- Revision
- 227733
- Author
- carlo...@webkit.org
- Date
- 2018-01-29 08:47:08 -0800 (Mon, 29 Jan 2018)
Log Message
WebDriver: ASSERTION FAILED: !m_loadTimer.isActive()
https://bugs.webkit.org/show_bug.cgi?id=182237
Reviewed by Carlos Alberto Lopez Perez.
We should stop the load timer when we dispatch the pending navigation callbacks due to an alert open.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::willShowJavaScriptDialog):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (227732 => 227733)
--- trunk/Source/WebKit/ChangeLog 2018-01-29 16:45:53 UTC (rev 227732)
+++ trunk/Source/WebKit/ChangeLog 2018-01-29 16:47:08 UTC (rev 227733)
@@ -1,3 +1,15 @@
+2018-01-29 Carlos Garcia Campos <cgar...@igalia.com>
+
+ WebDriver: ASSERTION FAILED: !m_loadTimer.isActive()
+ https://bugs.webkit.org/show_bug.cgi?id=182237
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ We should stop the load timer when we dispatch the pending navigation callbacks due to an alert open.
+
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::willShowJavaScriptDialog):
+
2018-01-29 Zan Dobersek <zdober...@igalia.com>
[Cairo] Add GraphicsContextImplCairo::createFactory() helpers
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (227732 => 227733)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-01-29 16:45:53 UTC (rev 227732)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-01-29 16:47:08 UTC (rev 227733)
@@ -560,6 +560,7 @@
return;
if (page->pageLoadState().isLoading()) {
+ m_loadTimer.stop();
respondToPendingFrameNavigationCallbacksWithTimeout(m_pendingNormalNavigationInBrowsingContextCallbacksPerFrame);
respondToPendingPageNavigationCallbacksWithTimeout(m_pendingNormalNavigationInBrowsingContextCallbacksPerPage);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
