Title: [227751] trunk/Source/WebKit
- Revision
- 227751
- Author
- [email protected]
- Date
- 2018-01-29 13:20:49 -0800 (Mon, 29 Jan 2018)
Log Message
Make sure we do not re-enter Webcore during StorageToWebProcessConnection::EstablishSWServerConnection Sync IPC
https://bugs.webkit.org/show_bug.cgi?id=182256
<rdar://problem/36689233>
Reviewed by Simon Fraser.
Make sure we do not re-enter Webcore during StorageToWebProcessConnection::EstablishSWServerConnection Sync IPC as
this can lead to crashes such as the one in <rdar://problem/36689233>.
* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::WebSWClientConnection):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (227750 => 227751)
--- trunk/Source/WebKit/ChangeLog 2018-01-29 20:38:37 UTC (rev 227750)
+++ trunk/Source/WebKit/ChangeLog 2018-01-29 21:20:49 UTC (rev 227751)
@@ -1,3 +1,17 @@
+2018-01-29 Chris Dumez <[email protected]>
+
+ Make sure we do not re-enter Webcore during StorageToWebProcessConnection::EstablishSWServerConnection Sync IPC
+ https://bugs.webkit.org/show_bug.cgi?id=182256
+ <rdar://problem/36689233>
+
+ Reviewed by Simon Fraser.
+
+ Make sure we do not re-enter Webcore during StorageToWebProcessConnection::EstablishSWServerConnection Sync IPC as
+ this can lead to crashes such as the one in <rdar://problem/36689233>.
+
+ * WebProcess/Storage/WebSWClientConnection.cpp:
+ (WebKit::WebSWClientConnection::WebSWClientConnection):
+
2018-01-29 Jan-Michael Brummer <[email protected]>
[GTK] Zooming gesture incorrectly uses scale instead of zoom
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp (227750 => 227751)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp 2018-01-29 20:38:37 UTC (rev 227750)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp 2018-01-29 21:20:49 UTC (rev 227751)
@@ -53,7 +53,7 @@
, m_connection(connection)
, m_swOriginTable(makeUniqueRef<WebSWOriginTable>())
{
- bool result = sendSync(Messages::StorageToWebProcessConnection::EstablishSWServerConnection(sessionID), Messages::StorageToWebProcessConnection::EstablishSWServerConnection::Reply(m_identifier));
+ bool result = sendSync(Messages::StorageToWebProcessConnection::EstablishSWServerConnection(sessionID), Messages::StorageToWebProcessConnection::EstablishSWServerConnection::Reply(m_identifier), Seconds::infinity(), IPC::SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply);
ASSERT_UNUSED(result, result);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
