Title: [227825] branches/safari-605-branch/LayoutTests
- Revision
- 227825
- Author
- [email protected]
- Date
- 2018-01-30 10:51:18 -0800 (Tue, 30 Jan 2018)
Log Message
Cherry-pick r227712. rdar://problem/37019428
Modified Paths
Diff
Modified: branches/safari-605-branch/LayoutTests/ChangeLog (227824 => 227825)
--- branches/safari-605-branch/LayoutTests/ChangeLog 2018-01-30 18:51:16 UTC (rev 227824)
+++ branches/safari-605-branch/LayoutTests/ChangeLog 2018-01-30 18:51:18 UTC (rev 227825)
@@ -1,5 +1,23 @@
2018-01-30 Jason Marcell <[email protected]>
+ Cherry-pick r227712. rdar://problem/37019428
+
+ 2018-01-26 Chris Dumez <[email protected]>
+
+ Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=182184
+ <rdar://problem/36929478>
+
+ Reviewed by Youenn Fablet.
+
+ Stop relying on a setTimeout(500) to end the test. Instead rely on the
+ internals.setConsoleMessageListener() API to wait for the console message
+ we are expecting.
+
+ * http/wpt/beacon/beacon-async-error-logging.html:
+
+2018-01-30 Jason Marcell <[email protected]>
+
Cherry-pick r227710. rdar://problem/37019457
2018-01-26 Megan Gardner <[email protected]>
Modified: branches/safari-605-branch/LayoutTests/http/wpt/beacon/beacon-async-error-logging.html (227824 => 227825)
--- branches/safari-605-branch/LayoutTests/http/wpt/beacon/beacon-async-error-logging.html 2018-01-30 18:51:16 UTC (rev 227824)
+++ branches/safari-605-branch/LayoutTests/http/wpt/beacon/beacon-async-error-logging.html 2018-01-30 18:51:18 UTC (rev 227825)
@@ -7,11 +7,15 @@
<body>
<script>
async_test(function(t) {
+ if (window.internals) {
+ internals.setConsoleMessageListener(function() {
+ t.done();
+ });
+ } else {
+ setTimeout(function() { t.done(); }, 500);
+ }
let invalidHost = "http://invalid.localhost";
assert_true(navigator.sendBeacon(invalidHost, 'test'), "sendBeacon should return true");
- setTimeout(function() {
- t.done();
- }, 500);
}, "Should log an error message in the console");
</script>
</body>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
