Title: [227894] trunk/Tools
Revision
227894
Author
[email protected]
Date
2018-01-31 01:17:50 -0800 (Wed, 31 Jan 2018)

Log Message

Unreviewed, rolling out r227782.

It didn't fix the problem

Reverted changeset:

"Unreviewed. Try to avoid webdriver tests step timing out in
the bots."
https://trac.webkit.org/changeset/227782

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (227893 => 227894)


--- trunk/Tools/ChangeLog	2018-01-31 09:14:33 UTC (rev 227893)
+++ trunk/Tools/ChangeLog	2018-01-31 09:17:50 UTC (rev 227894)
@@ -1,5 +1,17 @@
 2018-01-31  Carlos Garcia Campos  <[email protected]>
 
+        Unreviewed, rolling out r227782.
+
+        It didn't fix the problem
+
+        Reverted changeset:
+
+        "Unreviewed. Try to avoid webdriver tests step timing out in
+        the bots."
+        https://trac.webkit.org/changeset/227782
+
+2018-01-31  Carlos Garcia Campos  <[email protected]>
+
         WebDriver: add domains to server config in w3c tests
         https://bugs.webkit.org/show_bug.cgi?id=182294
 

Modified: trunk/Tools/Scripts/run-webdriver-tests (227893 => 227894)


--- trunk/Tools/Scripts/run-webdriver-tests	2018-01-31 09:14:33 UTC (rev 227893)
+++ trunk/Tools/Scripts/run-webdriver-tests	2018-01-31 09:17:50 UTC (rev 227894)
@@ -74,14 +74,6 @@
         print '*** Warning: jhbuild environment not present. Run update-webkitgtk-libs before build-webkit to ensure proper testing.'
         print '***'
 
-if options.json_output is not None:
-    # Create the json output file now, because buildbot watches it and it seems
-    # that creating it a t once after the tests causes problems.
-    directory = os.path.dirname(options.json_output)
-    if directory and not os.path.exists(directory):
-        os.makedirs(directory)
-    open(options.json_output, 'wb').close()
-
 port._display_server = options.display_server
 runner = WebDriverTestRunner(port)
 runner.run(args)

Modified: trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py (227893 => 227894)


--- trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py	2018-01-31 09:14:33 UTC (rev 227893)
+++ trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py	2018-01-31 09:17:50 UTC (rev 227894)
@@ -152,5 +152,9 @@
                 results['subtests'].append(subtest)
             json_results['results'].append(results)
 
+        directory = os.path.dirname(output_path)
+        if directory and not os.path.exists(directory):
+            os.makedirs(directory)
+
         with open(output_path, 'wb') as fp:
             json.dump(json_results, fp)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to