Title: [227902] trunk/Source/WebCore
- Revision
- 227902
- Author
- [email protected]
- Date
- 2018-01-31 08:14:32 -0800 (Wed, 31 Jan 2018)
Log Message
[GStreamer] Silent WebAudio buffers support
https://bugs.webkit.org/show_bug.cgi?id=143869
Reviewed by Carlos Garcia Campos.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Flag silent buffers as GAP buffers. This
enables downstream elements to optimize the buffer processing.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227901 => 227902)
--- trunk/Source/WebCore/ChangeLog 2018-01-31 16:11:57 UTC (rev 227901)
+++ trunk/Source/WebCore/ChangeLog 2018-01-31 16:14:32 UTC (rev 227902)
@@ -1,3 +1,14 @@
+2018-01-31 Philippe Normand <[email protected]>
+
+ [GStreamer] Silent WebAudio buffers support
+ https://bugs.webkit.org/show_bug.cgi?id=143869
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+ (webKitWebAudioSrcLoop): Flag silent buffers as GAP buffers. This
+ enables downstream elements to optimize the buffer processing.
+
2018-01-31 Xabier Rodriguez Calvar <[email protected]>
[EME] Fix NavigatorEME::tryNextSupportedConfiguration typo
Modified: trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (227901 => 227902)
--- trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2018-01-31 16:11:57 UTC (rev 227901)
+++ trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2018-01-31 16:14:32 UTC (rev 227902)
@@ -353,6 +353,13 @@
auto& buffer = channelBufferList[i];
unmapGstBuffer(buffer.get());
+ // This is enabled only for GStreamer 1.12.5 because of a memory leak that was fixed in that version.
+ // https://bugzilla.gnome.org/show_bug.cgi?id=793067
+ if (webkitGstCheckVersion(1, 12, 5)) {
+ if (priv->bus->channel(i)->isSilent())
+ GST_BUFFER_FLAG_SET(buffer.get(), GST_BUFFER_FLAG_GAP);
+ }
+
if (failed)
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
