Title: [227954] trunk/Source
- Revision
- 227954
- Author
- [email protected]
- Date
- 2018-01-31 23:28:10 -0800 (Wed, 31 Jan 2018)
Log Message
Use different debug red colors for different contexts
https://bugs.webkit.org/show_bug.cgi?id=182362
Reviewed by Tim Horton.
Source/WebCore:
Pure red is used elsehwere in the system as a debug color indicator, so use different
shades of red for WebKit in the two places where we paint a reddish wash in debug builds,
so they are identifiable.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
Source/WebKit:
Pure red is used elsehwere in the system as a debug color indicator, so use different
shades of red for WebKit in the two places where we paint a reddish wash in debug builds,
so they are identifiable.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227953 => 227954)
--- trunk/Source/WebCore/ChangeLog 2018-02-01 07:12:09 UTC (rev 227953)
+++ trunk/Source/WebCore/ChangeLog 2018-02-01 07:28:10 UTC (rev 227954)
@@ -1,3 +1,17 @@
+2018-01-31 Simon Fraser <[email protected]>
+
+ Use different debug red colors for different contexts
+ https://bugs.webkit.org/show_bug.cgi?id=182362
+
+ Reviewed by Tim Horton.
+
+ Pure red is used elsehwere in the system as a debug color indicator, so use different
+ shades of red for WebKit in the two places where we paint a reddish wash in debug builds,
+ so they are identifiable.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+
2018-01-31 Don Olmstead <[email protected]>
[CMake] Make _javascript_Core headers copies
Modified: trunk/Source/WebCore/page/FrameView.cpp (227953 => 227954)
--- trunk/Source/WebCore/page/FrameView.cpp 2018-02-01 07:12:09 UTC (rev 227953)
+++ trunk/Source/WebCore/page/FrameView.cpp 2018-02-01 07:28:10 UTC (rev 227954)
@@ -4070,22 +4070,22 @@
void FrameView::paintContents(GraphicsContext& context, const IntRect& dirtyRect, SecurityOriginPaintPolicy securityOriginPaintPolicy)
{
#ifndef NDEBUG
- bool fillWithRed;
+ bool fillWithWarningColor;
if (frame().document()->printing())
- fillWithRed = false; // Printing, don't fill with red (can't remember why).
+ fillWithWarningColor = false; // Printing, don't fill with red (can't remember why).
else if (frame().ownerElement())
- fillWithRed = false; // Subframe, don't fill with red.
+ fillWithWarningColor = false; // Subframe, don't fill with red.
else if (isTransparent())
- fillWithRed = false; // Transparent, don't fill with red.
+ fillWithWarningColor = false; // Transparent, don't fill with red.
else if (m_paintBehavior & PaintBehaviorSelectionOnly)
- fillWithRed = false; // Selections are transparent, don't fill with red.
+ fillWithWarningColor = false; // Selections are transparent, don't fill with red.
else if (m_nodeToDraw)
- fillWithRed = false; // Element images are transparent, don't fill with red.
+ fillWithWarningColor = false; // Element images are transparent, don't fill with red.
else
- fillWithRed = true;
+ fillWithWarningColor = true;
- if (fillWithRed)
- context.fillRect(dirtyRect, Color(0xFF, 0, 0));
+ if (fillWithWarningColor)
+ context.fillRect(dirtyRect, Color(255, 64, 255));
#endif
RenderView* renderView = this->renderView();
Modified: trunk/Source/WebKit/ChangeLog (227953 => 227954)
--- trunk/Source/WebKit/ChangeLog 2018-02-01 07:12:09 UTC (rev 227953)
+++ trunk/Source/WebKit/ChangeLog 2018-02-01 07:28:10 UTC (rev 227954)
@@ -1,3 +1,17 @@
+2018-01-31 Simon Fraser <[email protected]>
+
+ Use different debug red colors for different contexts
+ https://bugs.webkit.org/show_bug.cgi?id=182362
+
+ Reviewed by Tim Horton.
+
+ Pure red is used elsehwere in the system as a debug color indicator, so use different
+ shades of red for WebKit in the two places where we paint a reddish wash in debug builds,
+ so they are identifiable.
+
+ * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+ (WebKit::RemoteLayerBackingStore::drawInContext):
+
2018-01-31 Don Olmstead <[email protected]>
[CMake] Make _javascript_Core headers copies
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (227953 => 227954)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2018-02-01 07:12:09 UTC (rev 227953)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2018-02-01 07:28:10 UTC (rev 227954)
@@ -337,7 +337,7 @@
#ifndef NDEBUG
if (m_isOpaque)
- context.fillRect(scaledLayerBounds, Color(255, 0, 0));
+ context.fillRect(scaledLayerBounds, Color(255, 47, 146));
#endif
context.scale(m_scale);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
