Title: [227957] trunk/Tools
- Revision
- 227957
- Author
- [email protected]
- Date
- 2018-02-01 01:44:39 -0800 (Thu, 01 Feb 2018)
Log Message
[GTK] MiniBrowser settings are just a list of names
https://bugs.webkit.org/show_bug.cgi?id=182005
Reviewed by Sergio Villar Senin.
The default size we are using is too small to show the values column, and the window is not resizable because
GObjectClass::constructed() is not called in the parent class.
* MiniBrowser/gtk/BrowserSettingsDialog.c:
(browser_settings_dialog_init): Use 600x400 as default size.
(browserSettingsDialogConstructed): Chain up to parent constructed.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (227956 => 227957)
--- trunk/Tools/ChangeLog 2018-02-01 09:01:01 UTC (rev 227956)
+++ trunk/Tools/ChangeLog 2018-02-01 09:44:39 UTC (rev 227957)
@@ -1,3 +1,17 @@
+2018-02-01 Carlos Garcia Campos <[email protected]>
+
+ [GTK] MiniBrowser settings are just a list of names
+ https://bugs.webkit.org/show_bug.cgi?id=182005
+
+ Reviewed by Sergio Villar Senin.
+
+ The default size we are using is too small to show the values column, and the window is not resizable because
+ GObjectClass::constructed() is not called in the parent class.
+
+ * MiniBrowser/gtk/BrowserSettingsDialog.c:
+ (browser_settings_dialog_init): Use 600x400 as default size.
+ (browserSettingsDialogConstructed): Chain up to parent constructed.
+
2018-01-31 Andres Gomez <[email protected]>
Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
Modified: trunk/Tools/MiniBrowser/gtk/BrowserSettingsDialog.c (227956 => 227957)
--- trunk/Tools/MiniBrowser/gtk/BrowserSettingsDialog.c 2018-02-01 09:01:01 UTC (rev 227956)
+++ trunk/Tools/MiniBrowser/gtk/BrowserSettingsDialog.c 2018-02-01 09:44:39 UTC (rev 227957)
@@ -126,7 +126,8 @@
GtkBox *contentArea = GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(dialog)));
gtk_box_set_spacing(contentArea, 2);
- gtk_window_set_default_size(GTK_WINDOW(dialog), 400, 300);
+ gtk_window_set_default_size(GTK_WINDOW(dialog), 600, 400);
+ gtk_window_set_type_hint(GTK_WINDOW(dialog), GDK_WINDOW_TYPE_HINT_DIALOG);
gtk_window_set_title(GTK_WINDOW(dialog), "WebKit View Settings");
gtk_window_set_destroy_with_parent(GTK_WINDOW(dialog), TRUE);
gtk_container_set_border_width(GTK_CONTAINER(dialog), 5);
@@ -160,6 +161,8 @@
static void browserSettingsDialogConstructed(GObject *object)
{
+ G_OBJECT_CLASS(browser_settings_dialog_parent_class)->constructed(object);
+
BrowserSettingsDialog *dialog = BROWSER_SETTINGS_DIALOG(object);
WebKitSettings *settings = dialog->settings;
GtkListStore *model = gtk_list_store_new(SETTINGS_LIST_N_COLUMNS, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
