Modified: trunk/Source/_javascript_Core/ChangeLog (227969 => 227970)
--- trunk/Source/_javascript_Core/ChangeLog 2018-02-01 17:22:35 UTC (rev 227969)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-02-01 17:27:06 UTC (rev 227970)
@@ -1,3 +1,16 @@
+2018-02-01 Michael Catanzaro <[email protected]>
+
+ -Wreturn-type warning in DFGObjectAllocationSinkingPhase.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=182389
+
+ Reviewed by Yusuke Suzuki.
+
+ Fix the warning.
+
+ As a bonus, remove a couple unreachable breaks for good measure.
+
+ * dfg/DFGObjectAllocationSinkingPhase.cpp:
+
2018-02-01 Chris Dumez <[email protected]>
Queue a microtask when a waitUntil() promise is settled
Modified: trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp (227969 => 227970)
--- trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp 2018-02-01 17:22:35 UTC (rev 227969)
+++ trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp 2018-02-01 17:27:06 UTC (rev 227970)
@@ -1532,7 +1532,6 @@
where->origin.withSemantic(
allocation.identifier()->origin.semantic),
OpInfo(executable));
- break;
}
case Allocation::Kind::Activation: {
@@ -1553,7 +1552,6 @@
where->origin.withSemantic(
allocation.identifier()->origin.semantic),
OpInfo(regExp));
- break;
}
default:
@@ -2306,7 +2304,6 @@
OpInfo(data),
Edge(base, KnownCellUse),
value->defaultEdge());
- break;
}
case ClosureVarPLoc: {
@@ -2316,7 +2313,6 @@
OpInfo(location.info()),
Edge(base, KnownCellUse),
value->defaultEdge());
- break;
}
case RegExpObjectLastIndexPLoc: {
@@ -2326,7 +2322,6 @@
OpInfo(true),
Edge(base, KnownCellUse),
value->defaultEdge());
- break;
}
default:
@@ -2333,6 +2328,8 @@
DFG_CRASH(m_graph, base, "Bad location kind");
break;
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
// This is a great way of asking value->isStillValid() without having to worry about getting
