Title: [228006] trunk/Source/WebCore
- Revision
- 228006
- Author
- commit-qu...@webkit.org
- Date
- 2018-02-02 05:54:14 -0800 (Fri, 02 Feb 2018)
Log Message
Unreviewed, rolling out r227964.
https://bugs.webkit.org/show_bug.cgi?id=182423
It broke several unit tests (Requested by KaL on #webkit).
Reverted changeset:
"[SOUP] Ensure domain is valid when converting a WebCore
Cookie to Soup"
https://bugs.webkit.org/show_bug.cgi?id=182328
https://trac.webkit.org/changeset/227964
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228005 => 228006)
--- trunk/Source/WebCore/ChangeLog 2018-02-02 13:46:47 UTC (rev 228005)
+++ trunk/Source/WebCore/ChangeLog 2018-02-02 13:54:14 UTC (rev 228006)
@@ -1,3 +1,17 @@
+2018-02-02 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r227964.
+ https://bugs.webkit.org/show_bug.cgi?id=182423
+
+ It broke several unit tests (Requested by KaL on #webkit).
+
+ Reverted changeset:
+
+ "[SOUP] Ensure domain is valid when converting a WebCore
+ Cookie to Soup"
+ https://bugs.webkit.org/show_bug.cgi?id=182328
+ https://trac.webkit.org/changeset/227964
+
2018-02-01 Chris Dumez <cdu...@apple.com>
When SW install fails, null out registration.installing before setting worker state to "redundant"
Modified: trunk/Source/WebCore/platform/network/soup/CookieSoup.cpp (228005 => 228006)
--- trunk/Source/WebCore/platform/network/soup/CookieSoup.cpp 2018-02-02 13:46:47 UTC (rev 228005)
+++ trunk/Source/WebCore/platform/network/soup/CookieSoup.cpp 2018-02-02 13:54:14 UTC (rev 228006)
@@ -60,13 +60,8 @@
if (name.isNull() || value.isNull() || domain.isNull() || path.isNull())
return nullptr;
- // soup_cookie_new() will handle the given domain as a hostname if it doesn't start with '.'.
- auto cookieDomain = domain.utf8();
- if (cookieDomain.length() && !g_hostname_is_ip_address(cookieDomain.data()) && cookieDomain.data()[0] != '.')
- cookieDomain = makeString('.', domain).utf8();
-
SoupCookie* soupCookie = soup_cookie_new(name.utf8().data(), value.utf8().data(),
- cookieDomain.data(), path.utf8().data(), -1);
+ domain.utf8().data(), path.utf8().data(), -1);
soup_cookie_set_http_only(soupCookie, httpOnly);
soup_cookie_set_secure(soupCookie, secure);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
