Title: [100727] trunk
Revision
100727
Author
[email protected]
Date
2011-11-17 22:57:05 -0800 (Thu, 17 Nov 2011)

Log Message

Remove initProgressEvent method
https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <[email protected]> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

* dom/ProgressEvent.cpp:
* dom/ProgressEvent.h:
* dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
* fast/events/init-events-expected.txt:
* fast/events/script-tests/init-events.js:
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (100726 => 100727)


--- trunk/LayoutTests/ChangeLog	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/ChangeLog	2011-11-18 06:57:05 UTC (rev 100727)
@@ -1,3 +1,24 @@
+2011-11-17  Kaustubh Atrawalkar  <[email protected]>
+
+        Remove initProgressEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71340
+
+        Reviewed by Adam Barth.
+
+        This method has been removed from the spec draft.
+        http://www.w3.org/TR/progress-events/#interface-progressevent
+
+        No new tests. Removed method. Updated expected results.
+
+        * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+        * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+        * fast/events/init-events-expected.txt:
+        * fast/events/script-tests/init-events.js:
+        * fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+        * platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+        * platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+        * platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
+
 2011-11-17  Adam Klein  <[email protected]>
 
         Move JS recursion counter from V8Proxy to V8BindingPerIsolateData

Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (100726 => 100727)


--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	2011-11-18 06:57:05 UTC (rev 100727)
@@ -51,8 +51,6 @@
 PASS nonNumericPolicy('document.body.attributes.item(x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createNodeIterator(document, x, null, false)') is 'any type allowed'
 PASS nonNumericPolicy('document.getElementsByTagName("div").item(x)') is 'any type allowed'
-PASS nonNumericPolicy('document.createEvent("ProgressEvent").initProgressEvent("a", false, false, false, x, 0)') is 'any type allowed'
-PASS nonNumericPolicy('document.createEvent("ProgressEvent").initProgressEvent("a", false, false, false, 0, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().setStart(document, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().setEnd(document, x)') is 'any type allowed'
 PASS nonNumericPolicy('document.createRange().comparePoint(document, x)') is 'any type allowed'

Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (100726 => 100727)


--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	2011-11-18 06:57:05 UTC (rev 100727)
@@ -301,11 +301,6 @@
 
 shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed'");
 
-// ProgressEvent
-
-shouldBe("nonNumericPolicy('document.createEvent(\"ProgressEvent\").initProgressEvent(\"a\", false, false, false, x, 0)')", "'any type allowed'");
-shouldBe("nonNumericPolicy('document.createEvent(\"ProgressEvent\").initProgressEvent(\"a\", false, false, false, 0, x)')", "'any type allowed'");
-
 // Range
 
 shouldBe("nonNumericPolicy('document.createRange().setStart(document, x)')", "'any type allowed'");

Modified: trunk/LayoutTests/fast/events/init-events-expected.txt (100726 => 100727)


--- trunk/LayoutTests/fast/events/init-events-expected.txt	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/fast/events/init-events-expected.txt	2011-11-18 06:57:05 UTC (rev 100727)
@@ -116,16 +116,6 @@
 PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrName is 'd'
 PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", null, 1001').attrName is 'null'
 PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrChange is 1001
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').type is 'a'
-PASS testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type is 'null'
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').bubbles is false
-PASS testInitEvent('Progress', '"a", true, false, false, 1001, 1002').bubbles is true
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').cancelable is false
-PASS testInitEvent('Progress', '"a", false, true, false, 1001, 1002').cancelable is true
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').lengthComputable is false
-PASS testInitEvent('Progress', '"a", false, false, true, 1001, 1002').lengthComputable is true
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').loaded is 1001
-PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').total is 1002
 PASS testInitEvent('Storage', '"a", false, false, "b", "c", "d", "e"').type is 'a'
 PASS testInitEvent('Storage', 'null, false, false, "b", "c", "d", "e"').type is 'null'
 PASS testInitEvent('Storage', '"a", false, false, "b", "c", "d", "e"').bubbles is false

Modified: trunk/LayoutTests/fast/events/script-tests/init-events.js (100726 => 100727)


--- trunk/LayoutTests/fast/events/script-tests/init-events.js	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/fast/events/script-tests/init-events.js	2011-11-18 06:57:05 UTC (rev 100727)
@@ -130,17 +130,6 @@
 shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", null, 1001').attrName", "'null'");
 shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", \"d\", 1001').attrChange", "1001");
 
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').type", "'a'");
-shouldBe("testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type", "'null'");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').bubbles", "false");
-shouldBe("testInitEvent('Progress', '\"a\", true, false, false, 1001, 1002').bubbles", "true");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').cancelable", "false");
-shouldBe("testInitEvent('Progress', '\"a\", false, true, false, 1001, 1002').cancelable", "true");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').lengthComputable", "false");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, true, 1001, 1002').lengthComputable", "true");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').loaded", "1001");
-shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').total", "1002");
-
 shouldBe("testInitEvent('Storage', '\"a\", false, false, \"b\", \"c\", \"d\", \"e\"').type", "'a'");
 shouldBe("testInitEvent('Storage', 'null, false, false, \"b\", \"c\", \"d\", \"e\"').type", "'null'");
 shouldBe("testInitEvent('Storage', '\"a\", false, false, \"b\", \"c\", \"d\", \"e\"').bubbles", "false");

Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (100726 => 100727)


--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:57:05 UTC (rev 100727)
@@ -52,9 +52,6 @@
 initEvent : 'function initEvent() {
     [native code]
 }'
-initProgressEvent : 'function initProgressEvent() {
-    [native code]
-}'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

Modified: trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (100726 => 100727)


--- trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:57:05 UTC (rev 100727)
@@ -50,7 +50,6 @@
 defaultPrevented : 'false'
 eventPhase : '2'
 initEvent : 'function initEvent() { [native code] }'
-initProgressEvent : 'function initProgressEvent() { [native code] }'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

Modified: trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (100726 => 100727)


--- trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:57:05 UTC (rev 100727)
@@ -50,7 +50,6 @@
 defaultPrevented : 'false'
 eventPhase : '2'
 initEvent : 'function initEvent() { [native code] }'
-initProgressEvent : 'function initProgressEvent() { [native code] }'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

Modified: trunk/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt (100726 => 100727)


--- trunk/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt	2011-11-18 06:57:05 UTC (rev 100727)
@@ -50,7 +50,6 @@
 defaultPrevented : 'false'
 eventPhase : '2'
 initEvent : 'function initEvent() { [native code] }'
-initProgressEvent : 'function initProgressEvent() { [native code] }'
 lengthComputable : 'false'
 loaded : '0'
 position : '0'

Modified: trunk/Source/WebCore/ChangeLog (100726 => 100727)


--- trunk/Source/WebCore/ChangeLog	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/Source/WebCore/ChangeLog	2011-11-18 06:57:05 UTC (rev 100727)
@@ -1,3 +1,19 @@
+2011-11-17  Kaustubh Atrawalkar  <[email protected]>
+
+        Remove initProgressEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71340
+
+        Reviewed by Adam Barth.
+
+        This method has been removed from the spec draft.
+        http://www.w3.org/TR/progress-events/#interface-progressevent
+
+        No new tests. Removed method.
+
+        * dom/ProgressEvent.cpp:
+        * dom/ProgressEvent.h:
+        * dom/ProgressEvent.idl:
+
 2011-11-17  Eunmi Lee  <[email protected]>
 
         [EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the

Modified: trunk/Source/WebCore/dom/ProgressEvent.cpp (100726 => 100727)


--- trunk/Source/WebCore/dom/ProgressEvent.cpp	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/Source/WebCore/dom/ProgressEvent.cpp	2011-11-18 06:57:05 UTC (rev 100727)
@@ -60,19 +60,6 @@
 {
 }
     
-void ProgressEvent::initProgressEvent(const AtomicString& typeArg, bool canBubbleArg, bool cancelableArg,
-    bool lengthComputableArg, unsigned long long loadedArg, unsigned long long totalArg)
-{    
-    if (dispatched())
-        return;
-
-    initEvent(typeArg, canBubbleArg, cancelableArg);
-
-    m_lengthComputable = lengthComputableArg;
-    m_loaded = loadedArg;
-    m_total = totalArg;
-}
-
 const AtomicString& ProgressEvent::interfaceName() const
 {
     return eventNames().interfaceForProgressEvent;

Modified: trunk/Source/WebCore/dom/ProgressEvent.h (100726 => 100727)


--- trunk/Source/WebCore/dom/ProgressEvent.h	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/Source/WebCore/dom/ProgressEvent.h	2011-11-18 06:57:05 UTC (rev 100727)
@@ -53,9 +53,6 @@
         return adoptRef(new ProgressEvent(type, initializer));
     }
 
-    void initProgressEvent(const AtomicString& typeArg, bool canBubbleArg, bool cancelableArg,
-        bool lengthComputableArg, unsigned long long loadedArg, unsigned long long totalArg);
-
     bool lengthComputable() const { return m_lengthComputable; }
     unsigned long long loaded() const { return m_loaded; }
     unsigned long long total() const { return m_total; }

Modified: trunk/Source/WebCore/dom/ProgressEvent.idl (100726 => 100727)


--- trunk/Source/WebCore/dom/ProgressEvent.idl	2011-11-18 06:14:11 UTC (rev 100726)
+++ trunk/Source/WebCore/dom/ProgressEvent.idl	2011-11-18 06:57:05 UTC (rev 100727)
@@ -31,13 +31,6 @@
         readonly attribute [InitializedByConstructor] boolean lengthComputable;
         readonly attribute [InitializedByConstructor] unsigned long long loaded;
         readonly attribute [InitializedByConstructor] unsigned long long total;
-
-        void initProgressEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
-                               in [Optional=CallWithDefaultValue] boolean canBubbleArg,
-                               in [Optional=CallWithDefaultValue] boolean cancelableArg,
-                               in [Optional=CallWithDefaultValue] boolean lengthComputableArg, 
-                               in [Optional=CallWithDefaultValue] unsigned long long loadedArg, 
-                               in [Optional=CallWithDefaultValue] unsigned long long totalArg);
     };
 
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to