Title: [228258] trunk/Source/WebCore
- Revision
- 228258
- Author
- [email protected]
- Date
- 2018-02-07 20:10:09 -0800 (Wed, 07 Feb 2018)
Log Message
ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() seen with http/tests/paymentrequest/payment-request-show-method.https.html
https://bugs.webkit.org/show_bug.cgi?id=182591
Reviewed by Youenn Fablet.
Fixes assertion failures in http/tests/paymentrequest/payment-request-show-method.https.html.
DOMPromise::whenSettled() calls the JSC API without first aquiring the API lock, and
r228195 added a call to whenSettled() where the lock is not guaranteed to be already
acquired.
Fix this by creating a JSLockHolder in DOMPromise::whenSettled().
* bindings/js/JSDOMPromise.cpp:
(WebCore::DOMPromise::whenSettled):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228257 => 228258)
--- trunk/Source/WebCore/ChangeLog 2018-02-08 03:30:34 UTC (rev 228257)
+++ trunk/Source/WebCore/ChangeLog 2018-02-08 04:10:09 UTC (rev 228258)
@@ -1,3 +1,21 @@
+2018-02-07 Andy Estes <[email protected]>
+
+ ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() seen with http/tests/paymentrequest/payment-request-show-method.https.html
+ https://bugs.webkit.org/show_bug.cgi?id=182591
+
+ Reviewed by Youenn Fablet.
+
+ Fixes assertion failures in http/tests/paymentrequest/payment-request-show-method.https.html.
+
+ DOMPromise::whenSettled() calls the JSC API without first aquiring the API lock, and
+ r228195 added a call to whenSettled() where the lock is not guaranteed to be already
+ acquired.
+
+ Fix this by creating a JSLockHolder in DOMPromise::whenSettled().
+
+ * bindings/js/JSDOMPromise.cpp:
+ (WebCore::DOMPromise::whenSettled):
+
2018-02-07 Ryan Haddad <[email protected]>
Unreviewed, rolling out r228243.
Modified: trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp (228257 => 228258)
--- trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp 2018-02-08 03:30:34 UTC (rev 228257)
+++ trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp 2018-02-08 04:10:09 UTC (rev 228258)
@@ -55,6 +55,7 @@
{
auto& state = *globalObject()->globalExec();
auto& vm = state.vm();
+ JSLockHolder lock(vm);
auto* handler = JSC::JSNativeStdFunction::create(vm, globalObject(), 1, String { }, [callback = WTFMove(callback)] (ExecState*) mutable {
callback();
return JSC::JSValue::encode(JSC::jsUndefined());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
