Title: [228281] trunk/Source/WebCore
- Revision
- 228281
- Author
- [email protected]
- Date
- 2018-02-08 10:38:29 -0800 (Thu, 08 Feb 2018)
Log Message
[GStreamer] WebKit improperly handles missing GStreamer elements
https://bugs.webkit.org/show_bug.cgi?id=171205
Reviewed by Michael Catanzaro.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Add a
test checking the videoflip element was correctly created. It
might not be available on some exotic distros such as Gentoo.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228280 => 228281)
--- trunk/Source/WebCore/ChangeLog 2018-02-08 18:18:21 UTC (rev 228280)
+++ trunk/Source/WebCore/ChangeLog 2018-02-08 18:38:29 UTC (rev 228281)
@@ -1,3 +1,15 @@
+2018-02-08 Philippe Normand <[email protected]>
+
+ [GStreamer] WebKit improperly handles missing GStreamer elements
+ https://bugs.webkit.org/show_bug.cgi?id=171205
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Add a
+ test checking the videoflip element was correctly created. It
+ might not be available on some exotic distros such as Gentoo.
+
2018-02-08 Chris Fleizach <[email protected]>
AX: Defer attribute computation until needed.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (228280 => 228281)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-02-08 18:18:21 UTC (rev 228280)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-02-08 18:38:29 UTC (rev 228281)
@@ -2185,8 +2185,11 @@
// If not using accelerated compositing, let GStreamer handle
// the image-orientation tag.
GstElement* videoFlip = gst_element_factory_make("videoflip", nullptr);
- g_object_set(videoFlip, "method", 8, nullptr);
- g_object_set(m_pipeline.get(), "video-filter", videoFlip, nullptr);
+ if (videoFlip) {
+ g_object_set(videoFlip, "method", 8, nullptr);
+ g_object_set(m_pipeline.get(), "video-filter", videoFlip, nullptr);
+ } else
+ GST_WARNING("The videoflip element is missing, video rotation support is now disabled. Please check your gst-plugins-good installation.");
}
GRefPtr<GstPad> videoSinkPad = adoptGRef(gst_element_get_static_pad(m_videoSink.get(), "sink"));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
