Title: [228283] trunk/Source/WebKit
Revision
228283
Author
[email protected]
Date
2018-02-08 11:31:00 -0800 (Thu, 08 Feb 2018)

Log Message

Unreviewed, rolling out r228262.

This broke an internal build alongside r228261.

Reverted changeset:

"WebDriver: addCookie command should prepend a dot to domain
if missing"
https://bugs.webkit.org/show_bug.cgi?id=182328
https://trac.webkit.org/changeset/228262

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (228282 => 228283)


--- trunk/Source/WebKit/ChangeLog	2018-02-08 18:55:32 UTC (rev 228282)
+++ trunk/Source/WebKit/ChangeLog	2018-02-08 19:31:00 UTC (rev 228283)
@@ -1,3 +1,16 @@
+2018-02-08  Matt Lewis  <[email protected]>
+
+        Unreviewed, rolling out r228262.
+
+        This broke an internal build alongside r228261.
+
+        Reverted changeset:
+
+        "WebDriver: addCookie command should prepend a dot to domain
+        if missing"
+        https://bugs.webkit.org/show_bug.cgi?id=182328
+        https://trac.webkit.org/changeset/228262
+
 2018-02-08  Miguel Gomez  <[email protected]>
 
         [GTK] WaylandCompositor misusing eglGetProcAddress

Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (228282 => 228283)


--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp	2018-02-08 18:55:32 UTC (rev 228282)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp	2018-02-08 19:31:00 UTC (rev 228283)
@@ -1207,12 +1207,7 @@
     // Inherit the domain/host from the main frame's URL if it is not explicitly set.
     if (domain.isEmpty())
         domain = activeURL.host();
-    else if (domain[0] != '.') {
-        // RFC 2965: If an explicitly specified value does not start with a dot, the user agent supplies a leading dot.
-        // Assume that any host that ends with a digit is trying to be an IP address.
-        if (!WebCore::URL::hostIsIPAddress(domain))
-            domain = makeString('.', domain);
-    }
+
     cookie.domain = domain;
 
     if (!cookieObject.getString(WTF::ASCIILiteral("path"), cookie.path))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to