Title: [228305] trunk
- Revision
- 228305
- Author
- [email protected]
- Date
- 2018-02-08 17:58:23 -0800 (Thu, 08 Feb 2018)
Log Message
[Meta][Win] Support ICU 59.1+
https://bugs.webkit.org/show_bug.cgi?id=181004
Patch by Fujii Hironori <[email protected]> on 2018-02-08
Reviewed by Alex Christensen.
ICU 59 changed the type of UChar from wchar_t to char16_t on
Windows. We need a lot of conversions between UChar* and wchar_t*
to call Windows API because it takes string as wchar_t*.
Fortunately, ICU is configurable to define UChar as wchar_t as
well as the prior ICU.
<http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
* Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
Modified Paths
Diff
Modified: trunk/ChangeLog (228304 => 228305)
--- trunk/ChangeLog 2018-02-09 01:32:55 UTC (rev 228304)
+++ trunk/ChangeLog 2018-02-09 01:58:23 UTC (rev 228305)
@@ -1,3 +1,20 @@
+2018-02-08 Fujii Hironori <[email protected]>
+
+ [Meta][Win] Support ICU 59.1+
+ https://bugs.webkit.org/show_bug.cgi?id=181004
+
+ Reviewed by Alex Christensen.
+
+ ICU 59 changed the type of UChar from wchar_t to char16_t on
+ Windows. We need a lot of conversions between UChar* and wchar_t*
+ to call Windows API because it takes string as wchar_t*.
+
+ Fortunately, ICU is configurable to define UChar as wchar_t as
+ well as the prior ICU.
+ <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
+
+ * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
+
2018-02-08 Michael Catanzaro <[email protected]>
Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
Modified: trunk/Source/cmake/OptionsWin.cmake (228304 => 228305)
--- trunk/Source/cmake/OptionsWin.cmake 2018-02-09 01:32:55 UTC (rev 228304)
+++ trunk/Source/cmake/OptionsWin.cmake 2018-02-09 01:58:23 UTC (rev 228305)
@@ -145,3 +145,4 @@
set(WebKitLegacy_LIBRARY_TYPE SHARED)
find_package(ICU REQUIRED)
+add_definitions(-DUCHAR_TYPE=wchar_t)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
