Title: [228351] trunk/Source/WebKit
Revision
228351
Author
ross.kirsl...@sony.com
Date
2018-02-09 20:44:39 -0800 (Fri, 09 Feb 2018)

Log Message

Remove invalidated WebPage::handleEditingKeyboardEvent default implementation after r228260.
https://bugs.webkit.org/show_bug.cgi?id=182663

Reviewed by Chris Dumez.

This would need to be updated to turn `keyEvent` into `underlyingPlatformEvent`;
instead, we can remove it, as it's only for Windows, which doesn't yet support WK2.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (228350 => 228351)


--- trunk/Source/WebKit/ChangeLog	2018-02-10 01:46:04 UTC (rev 228350)
+++ trunk/Source/WebKit/ChangeLog	2018-02-10 04:44:39 UTC (rev 228351)
@@ -1,3 +1,16 @@
+2018-02-09  Ross Kirsling  <ross.kirsl...@sony.com>
+
+        Remove invalidated WebPage::handleEditingKeyboardEvent default implementation after r228260.
+        https://bugs.webkit.org/show_bug.cgi?id=182663
+
+        Reviewed by Chris Dumez.
+
+        This would need to be updated to turn `keyEvent` into `underlyingPlatformEvent`;
+        instead, we can remove it, as it's only for Windows, which doesn't yet support WK2.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::handleEditingKeyboardEvent): Deleted.
+
 2018-02-09  Nan Wang  <n_w...@apple.com>
 
         AX: Accessibility is not notified when a web process cancels the suspension

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (228350 => 228351)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-02-10 01:46:04 UTC (rev 228350)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-02-10 04:44:39 UTC (rev 228351)
@@ -3297,42 +3297,6 @@
     return m_notificationPermissionRequestManager.get();
 }
 
-#if !PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WPE)
-
-bool WebPage::handleEditingKeyboardEvent(KeyboardEvent* evt)
-{
-    Frame* frame = downcast<Node>(*evt->target()).document().frame();
-    ASSERT(frame);
-
-    const PlatformKeyboardEvent* keyEvent = evt->keyEvent();
-    if (!keyEvent)
-        return false;
-
-    Editor::Command command = frame->editor().command(interpretKeyEvent(evt));
-
-    if (keyEvent->type() == PlatformEvent::RawKeyDown) {
-        // WebKit doesn't have enough information about mode to decide how commands that just insert text if executed via Editor should be treated,
-        // so we leave it upon WebCore to either handle them immediately (e.g. Tab that changes focus) or let a keypress event be generated
-        // (e.g. Tab that inserts a Tab character, or Enter).
-        return !command.isTextInsertion() && command.execute(evt);
-    }
-
-    if (command.execute(evt))
-        return true;
-
-    // Don't allow text insertion for nodes that cannot edit.
-    if (!frame->editor().canEdit())
-        return false;
-
-    // Don't insert null or control characters as they can result in unexpected behaviour
-    if (evt->charCode() < ' ')
-        return false;
-
-    return frame->editor().insertText(evt->keyEvent()->text(), evt);
-}
-
-#endif
-
 #if ENABLE(DRAG_SUPPORT)
 
 #if PLATFORM(GTK)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to